From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753056AbbC1ApL (ORCPT ); Fri, 27 Mar 2015 20:45:11 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:29100 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752249AbbC1ApG convert rfc822-to-8bit (ORCPT ); Fri, 27 Mar 2015 20:45:06 -0400 Date: Fri, 27 Mar 2015 20:44:59 -0400 From: Konrad Rzeszutek Wilk To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Bob Liu , xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, jennifer.herbert@citrix.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion() Message-ID: <20150328004459.GA14373@l.oracle.com> References: <1427372161-4964-1-git-send-email-bob.liu@oracle.com> <1427372161-4964-2-git-send-email-bob.liu@oracle.com> <5514269D.6050905@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <5514269D.6050905@citrix.com> User-Agent: Mutt/1.5.23 (2014-03-12) Content-Transfer-Encoding: 8BIT X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monné wrote: > El 26/03/15 a les 13.16, Bob Liu ha escrit: > > There are several place using gnttab async unmap and wait for > > completion, so move the common code to a function > > gnttab_unmap_refs_async_wait_completion(). > > > > Signed-off-by: Bob Liu > > For the blkback parts: > > Acked-by: Roger Pau Monné > > Although, as David already said, I think we should do better than BUG_ON > on error. Have an 'stuck deferred pages' list and an timer to occasionally flush them out? Something similar to 569ca5b3f94cd0b3295ec5943aa457cf4a4f6a3a "xen/gnttab: add deferred freeing logic" ? >