From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbbC3JMa (ORCPT ); Mon, 30 Mar 2015 05:12:30 -0400 Received: from casper.infradead.org ([85.118.1.10]:59495 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752905AbbC3JM3 (ORCPT ); Mon, 30 Mar 2015 05:12:29 -0400 Date: Mon, 30 Mar 2015 11:12:19 +0200 From: Peter Zijlstra To: Juri Lelli Cc: Ingo Molnar , Wanpeng Li , "linux-kernel@vger.kernel.org" , "juri.lelli@gmail.com" Subject: Re: [PATCH RESEND v10] sched/deadline: support dl task migration during cpu hotplug Message-ID: <20150330091219.GQ23123@twins.programming.kicks-ass.net> References: <1426231647-11966-1-git-send-email-wanpeng.li@linux.intel.com> <20150316150101.GA18521@gmail.com> <20150316230110.GA14994@kernel> <20150317080612.GA28235@gmail.com> <20150317075322.GA5431@kernel> <20150317081302.GA28462@gmail.com> <20150317075945.GA5646@kernel> <20150323072504.GA25184@gmail.com> <20150323085523.GB23123@twins.programming.kicks-ass.net> <55112DED.1060506@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55112DED.1060506@arm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 09:27:09AM +0000, Juri Lelli wrote: > Right, it should not happen. It happens because hotplug operations are > destructive w.r.t. cpusets. Peter, how about we move the check you put > in sched_cpu_inactive() to cpuset_cpu_inactive()? This way, if we fail, > we don't need to destroy/rebuild the domains. Seems ok to my Monday brain, could you shoot a coherent Changelog this way so that I can copy/paste it into the patch?