From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753782AbbC3Oro (ORCPT ); Mon, 30 Mar 2015 10:47:44 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:34485 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753150AbbC3Ork (ORCPT ); Mon, 30 Mar 2015 10:47:40 -0400 Date: Mon, 30 Mar 2015 16:49:27 +0200 From: Daniel Vetter To: Gerd Hoffmann Cc: Daniel Vetter , virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" , "open list:ABI/API" , Rusty Russell , open list , "open list:DRM DRIVERS" , "open list:VIRTIO CORE, NET..." , Dave Airlie Subject: Re: [PATCH] Add virtio gpu driver. Message-ID: <20150330144927.GN23521@phenom.ffwll.local> Mail-Followup-To: Gerd Hoffmann , virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" , "open list:ABI/API" , Rusty Russell , open list , "open list:DRM DRIVERS" , "open list:VIRTIO CORE, NET..." , Dave Airlie References: <1427213239-8775-1-git-send-email-kraxel@redhat.com> <20150324165057.GN1349@phenom.ffwll.local> <1427718227.3372.33.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427718227.3372.33.camel@nilsson.home.kraxel.org> X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2015 at 02:23:47PM +0200, Gerd Hoffmann wrote: > Hi, > > > > Signed-off-by: Dave Airlie > > > Signed-off-by: Gerd Hoffmann > > > > Standard request from my side for new drm drivers (especially if they're > > this simple): Can you please update the drivers to latest drm internal > > interfaces, i.e. using universal planes and atomic? > > Up'n'running. Incremental patch: > > https://www.kraxel.org/cgit/linux/commit/?h=virtio-gpu-2d&id=b8edf4f38a1ec5a50f6ac8948521a12f862d3d5a > > v2 coming, but I'll go over the other reviews first. Looking good. Wrt pageflip the current MO is to handroll it in your driver, common approach is to use the msm async commit implementation msm_atomic_commit. The issue is simply that right now there's still no useable generic vblank callback support (drm_irq.c is a mess) hence why the core helpers don't support async flips yet. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch