From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753362AbbC3Viu (ORCPT ); Mon, 30 Mar 2015 17:38:50 -0400 Received: from smtprelay0011.hostedemail.com ([216.40.44.11]:56181 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752983AbbC3Vis (ORCPT ); Mon, 30 Mar 2015 17:38:48 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2376:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4362:5007:6119:6261:7875:7903:8784:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12517:12519:12663:12681:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: mass83_4ca327f00a049 X-Filterd-Recvd-Size: 1859 Date: Mon, 30 Mar 2015 17:38:45 -0400 From: Steven Rostedt To: Dave Hansen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, dave.hansen@linux.intel.com Subject: Re: [PATCH 03/17] x86, mpx: trace #BR exceptions Message-ID: <20150330173845.74d638e2@gandalf.local.home> In-Reply-To: <5519C12A.8080904@sr71.net> References: <20150327215253.8583D538@viggo.jf.intel.com> <20150327215259.76E37BE5@viggo.jf.intel.com> <20150330212528.GI3042@home.goodmis.org> <5519C12A.8080904@sr71.net> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Mar 2015 14:33:30 -0700 Dave Hansen wrote: > On 03/30/2015 02:25 PM, Steven Rostedt wrote: > ... > >> > +#ifdef CONFIG_X86_INTEL_MPX I missed this #ifdef > >> > + > >> > +TRACE_EVENT(bounds_exception_mpx, > ... > >> > + TP_printk("bndcfgu:0x%llx bndstatus:0x%llx", > >> > + __entry->bndcfgu, > >> > + __entry->bndstatus) > >> > +); > >> > + > >> > +#else > >> > + > >> > +/* > >> > + * This gets used outside of MPX-specific code, so we need a stub. > >> > + */ > > I'm a bit confused by this. What exactly is used outside of MPX-specific code? > > Does it break the build without this? > > It gets used in arch/x86/kernel/traps.c. There's a point when we've > decided that the #BR exception is an MPX-specific one and that's where > we'd like the tracepoint to be. > > Yes, it breaks the build without this. Thanks for the explanation. -- Steve