From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669AbbC3Rxo (ORCPT ); Mon, 30 Mar 2015 13:53:44 -0400 Received: from mga11.intel.com ([192.55.52.93]:65416 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753629AbbC3Rxl (ORCPT ); Mon, 30 Mar 2015 13:53:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,495,1422950400"; d="scan'208";a="672718320" Date: Mon, 30 Mar 2015 23:19:10 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: linux@arm.linux.org.uk, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jonas Jensen Subject: Re: [PATCH 5/5] dmaengine: moxart-dma: Fix memory leak when stopping a running transfer Message-ID: <20150330174910.GO7192@intel.com> References: <1427456155-28990-1-git-send-email-peter.ujfalusi@ti.com> <1427456155-28990-6-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427456155-28990-6-git-send-email-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 01:35:55PM +0200, Peter Ujfalusi wrote: > The vd->node is removed from the lists when the transfer started so the > vchan_get_all_descriptors() will not find it. This results memory leak. > > Signed-off-by: Peter Ujfalusi > CC: Jonas Jensen Applied, thanks -- ~Vinod > --- > drivers/dma/moxart-dma.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c > index 15cab7d79525..b4634109e010 100644 > --- a/drivers/dma/moxart-dma.c > +++ b/drivers/dma/moxart-dma.c > @@ -193,8 +193,10 @@ static int moxart_terminate_all(struct dma_chan *chan) > > spin_lock_irqsave(&ch->vc.lock, flags); > > - if (ch->desc) > + if (ch->desc) { > + moxart_dma_desc_free(&ch->desc->vd); > ch->desc = NULL; > + } > > ctrl = readl(ch->base + REG_OFF_CTRL); > ctrl &= ~(APB_DMA_ENABLE | APB_DMA_FIN_INT_EN | APB_DMA_ERR_INT_EN); > -- > 2.3.3 > --