From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754611AbbC3USl (ORCPT ); Mon, 30 Mar 2015 16:18:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55438 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754547AbbC3URh (ORCPT ); Mon, 30 Mar 2015 16:17:37 -0400 Date: Mon, 30 Mar 2015 17:17:21 -0300 From: Eduardo Habkost To: Michael Mueller Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson , Daniel Hansel Subject: Re: [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model Message-ID: <20150330201721.GF7031@thinpad.lan.raisama.net> References: <1427725708-52100-1-git-send-email-mimu@linux.vnet.ibm.com> <1427725708-52100-12-git-send-email-mimu@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427725708-52100-12-git-send-email-mimu@linux.vnet.ibm.com> X-Fnord: you can see the fnord User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > This patch implements a new QMP request named 'query-cpu-model'. > It returns the cpu model of cpu 0 and its backing accelerator. > > request: > {"execute" : "query-cpu-model" } > > answer: > {"return" : {"name": "2827-ga2", "accel": "kvm" }} If you are returning information about an existing CPU, why not just extend the output of "query-cpus"? (Existing qmp_query_cpus() calls cpu_synchronize_state(), which may be undesired. But in this case we could add an optional parameter to disable the return of data that requires stopping the VCPU). > > Alias names are resolved to their respective machine type and GA names > already during cpu instantiation. Thus, also a cpu model like 'host' > which is implemented as alias will return its normalized cpu model name. > > Furthermore the patch implements the following function: > > - s390_cpu_models_used(), returns true if S390 cpu models are in use > > Signed-off-by: Michael Mueller [...] -- Eduardo