From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754927AbbCaPSL (ORCPT ); Tue, 31 Mar 2015 11:18:11 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47681 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754894AbbCaPR4 (ORCPT ); Tue, 31 Mar 2015 11:17:56 -0400 Date: Tue, 31 Mar 2015 11:17:52 -0400 (EDT) Message-Id: <20150331.111752.1605776715849912657.davem@davemloft.net> To: hideaki.yoshifuji@miraclelinux.com Cc: fabf@skynet.be, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, steffen.klassert@secunet.com, herbert@gondor.apana.org.au, pablo@netfilter.org, kadlec@blackhole.kfki.hu, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH 4/9 net-next] ipv6: replace if/BUG by BUG_ON From: David Miller In-Reply-To: <551A1983.40408@miraclelinux.com> References: <1427749998-28464-1-git-send-email-fabf@skynet.be> <1427749998-28464-4-git-send-email-fabf@skynet.be> <551A1983.40408@miraclelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 31 Mar 2015 08:17:55 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YOSHIFUJI Hideaki Date: Tue, 31 Mar 2015 12:50:27 +0900 > Hi, > > Fabian Frederick wrote: >> Signed-off-by: Fabian Frederick >> --- >> net/ipv6/addrconf.c | 3 +-- >> net/ipv6/esp6.c | 3 +-- >> net/ipv6/netfilter/nf_conntrack_reasm.c | 3 +-- >> 3 files changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c >> index 2660263..e205918 100644 >> --- a/net/ipv6/addrconf.c >> +++ b/net/ipv6/addrconf.c >> @@ -4805,8 +4805,7 @@ static int inet6_set_link_af(struct net_device *dev, const struct nlattr *nla) >> if (!idev) >> return -EAFNOSUPPORT; >> >> - if (nla_parse_nested(tb, IFLA_INET6_MAX, nla, NULL) < 0) >> - BUG(); >> + BUG_ON(nla_parse_nested(tb, IFLA_INET6_MAX, nla, NULL) < 0); >> > > NACK, I do not prefer using BUG_ON() with side effects. Agreed, I do not like these changes at all and will not be applying them.