From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Chanwoo Choi <cw00.choi@samsung.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410
Date: Tue, 31 Mar 2015 02:27:09 +0200 [thread overview]
Message-ID: <20150331002709.GF3849@piout.net> (raw)
In-Reply-To: <1427728773-29065-2-git-send-email-k.kozlowski@samsung.com>
nitpick: I would prefer rtc: rtc-s3c instead of drivers/rtc/rtc-s3c.c
On 30/03/2015 at 17:19:32 +0200, Krzysztof Kozlowski wrote :
> There are now no differences between RTC on Exynos3250 and S3C6410.
> Merge everything into one so duplicated code could be removed.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/rtc-s3c.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index fb0c569765c6..5e162eaad277 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -774,18 +774,6 @@ static struct s3c_rtc_data const s3c6410_rtc_data = {
> .disable = s3c6410_rtc_disable,
> };
>
> -static struct s3c_rtc_data const exynos3250_rtc_data = {
> - .max_user_freq = 32768,
> - .needs_src_clk = true,
> - .irq_handler = s3c6410_rtc_irq,
> - .set_freq = s3c6410_rtc_setfreq,
> - .enable_tick = s3c6410_rtc_enable_tick,
> - .save_tick_cnt = s3c6410_rtc_save_tick_cnt,
> - .restore_tick_cnt = s3c6410_rtc_restore_tick_cnt,
> - .enable = s3c24xx_rtc_enable,
> - .disable = s3c6410_rtc_disable,
> -};
> -
> static const struct of_device_id s3c_rtc_dt_match[] = {
> {
> .compatible = "samsung,s3c2410-rtc",
> @@ -801,7 +789,7 @@ static const struct of_device_id s3c_rtc_dt_match[] = {
> .data = (void *)&s3c6410_rtc_data,
> }, {
> .compatible = "samsung,exynos3250-rtc",
> - .data = (void *)&exynos3250_rtc_data,
> + .data = (void *)&s3c6410_rtc_data,
> },
> { /* sentinel */ },
> };
> --
> 1.9.1
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-31 0:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 15:19 [PATCH 0/2] ARM: EXYNOS: Minor S3C RTC cleanups Krzysztof Kozlowski
2015-03-30 15:19 ` [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410 Krzysztof Kozlowski
2015-03-30 23:37 ` Chanwoo Choi
2015-03-31 0:27 ` Alexandre Belloni [this message]
2015-03-31 6:49 ` Javier Martinez Canillas
2015-03-31 8:20 ` Alexandre Belloni
2015-03-31 9:00 ` [rtc-linux] " Krzysztof Kozlowski
2015-03-30 15:19 ` [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc Krzysztof Kozlowski
2015-03-30 23:38 ` Chanwoo Choi
2015-03-31 0:31 ` Alexandre Belloni
2015-03-31 0:47 ` Chanwoo Choi
2015-03-31 8:12 ` Alexandre Belloni
2015-03-31 8:56 ` [rtc-linux] " Krzysztof Kozlowski
2015-03-31 6:43 ` Javier Martinez Canillas
2015-03-31 6:54 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331002709.GF3849@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).