From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751740AbbCaEpg (ORCPT ); Tue, 31 Mar 2015 00:45:36 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35081 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbbCaEpd (ORCPT ); Tue, 31 Mar 2015 00:45:33 -0400 Date: Tue, 31 Mar 2015 13:45:25 +0900 From: Minchan Kim To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Johannes Weiner , Mel Gorman , Rik van Riel , Shaohua Li , Yalin.Wang@sonymobile.com Subject: Re: [PATCH 3/4] mm: move lazy free pages to inactive list Message-ID: <20150331044525.GB16825@blaptop> References: <1426036838-18154-1-git-send-email-minchan@kernel.org> <1426036838-18154-3-git-send-email-minchan@kernel.org> <20150320154358.51bcf3cbceeb8fbbdb2b58e5@linux-foundation.org> <20150330053502.GB3008@blaptop> <20150330142010.5d14fbc07e05180cc3ecce5c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150330142010.5d14fbc07e05180cc3ecce5c@linux-foundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andrew, On Mon, Mar 30, 2015 at 02:20:10PM -0700, Andrew Morton wrote: > On Mon, 30 Mar 2015 14:35:02 +0900 Minchan Kim wrote: > > > --- a/mm/swap.c > > +++ b/mm/swap.c > > @@ -866,6 +866,13 @@ void deactivate_file_page(struct page *page) > > } > > } > > > > +/** > > + * deactivate_page - deactivate a page > > + * @page: page to deactivate > > + * > > + * This function moves @page to inactive list if @page was on active list and > > + * was not unevictable page to accelerate to reclaim @page. > > + */ > > void deactivate_page(struct page *page) > > { > > if (PageLRU(page) && PageActive(page) && !PageUnevictable(page)) { > > Thanks. > > deactivate_page() doesn't look at or alter PageReferenced(). Should it? Absolutely true. Thanks. Here it goes. >>From 2b2c92eb73a1cceac615b9abd4c0f5f0c3395ff5 Mon Sep 17 00:00:00 2001 From: Minchan Kim Date: Tue, 31 Mar 2015 13:38:46 +0900 Subject: [PATCH] mm: lru_deactivate_fn should clear PG_referenced deactivate_page aims for accelerate for reclaiming through moving pages from active list to inactive list so we should clear PG_referenced for the goal. Suggested-by: Andrew Morton Signed-off-by: Minchan Kim --- mm/swap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/swap.c b/mm/swap.c index b65fc8c..6b420022 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -800,6 +800,7 @@ static void lru_deactivate_fn(struct page *page, struct lruvec *lruvec, del_page_from_lru_list(page, lruvec, lru + LRU_ACTIVE); ClearPageActive(page); + ClearPageReferenced(page); add_page_to_lru_list(page, lruvec, lru); __count_vm_event(PGDEACTIVATE); -- 1.9.3 -- Kind regards, Minchan Kim