From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbbCaF6g (ORCPT ); Tue, 31 Mar 2015 01:58:36 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36487 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbbCaF6d (ORCPT ); Tue, 31 Mar 2015 01:58:33 -0400 Date: Tue, 31 Mar 2015 06:58:06 +0100 From: Mark Brown To: Scott Branden Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Dmitry Torokhov , Anatol Pomazao , abrestic@google.com, bryeung@google.com, olofj@google.com, pwestin@google.com, Lori Hikichi Message-ID: <20150331055806.GB2869@sirena.org.uk> References: <1427771784-29950-1-git-send-email-sbranden@broadcom.com> <1427771784-29950-2-git-send-email-sbranden@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GLUG07LsNvqYBoXx" Content-Disposition: inline In-Reply-To: <1427771784-29950-2-git-send-email-sbranden@broadcom.com> X-Cookie: Wanna buy a duck? User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GLUG07LsNvqYBoXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 30, 2015 at 08:16:23PM -0700, Scott Branden wrote: > +SSP Subnode properties: > +- dai-name: The name of the DAI registered with ASOC ASoC. Why is this in the DT - it sounds like this is just an internal implementation detail for Linux, not a property of the hardware. > +- mode: Controls if this port should be configured as I2S or TDM mode. > + Valid values are: "tdm" or "i2s" > +- tdm-bits-per-frame: only if mode is "tdm" then this property must set. > + Valid values are (128/256/512) We'd normally leave these up to the machine driver to set as they're link wide things for system integration. The bits per frame in particular looks like something that's not going to be fixed by the hardware and could be varied at runtime. > +- port-status: Controls if port is enabled or not > + Valid values "enabled" or "disabled" This sounds like it's replicating the DT standard status property? > +- channel-group: Control grouping of serial port > + Valid values are "2_0", "3_1", or "5_1" What does this mean? It looks like it's setting the number of channels which again seems like a runtime thing. --GLUG07LsNvqYBoXx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVGjduAAoJECTWi3JdVIfQu48H/1fN7LiL7Q1KKED+fWLN6nPb 6t8INocmBJfGooSDZJFtYNmfyaW6ZbaMl+eFgnVadAB5v5Bcsvpbo5knImr3gBEm dzTTe0nmKCylkzDuC9ox+4lcgrmfj+DvEHyL5OdoQSRt1NP9dLyFjmLUzJaI39/A hejBHriJpSRLb1tWb7w8k1AftoZwRUiIuqQ2noRuXUzIJD8lE/ofpdezNt47hClk 6uu1zSDL5zqP6EMEYrwUgm0n5zE0Gqv08LBiVFoIVWZQLTSmk2WBJnlFNjo+rJSL 4ZUNzKHW0XVOb15SJnkskjMVOkxxClyJkJXgSOI+x7+uCFk68u5tgHG/iLm5SGw= =zmeu -----END PGP SIGNATURE----- --GLUG07LsNvqYBoXx--