From: Ingo Molnar <mingo@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
maxime.ripard@free-electrons.com, viresh.kumar@linaro.org,
ben.dooks@codethink.co.uk, digetx@gmail.com, hdegoede@redhat.com,
laurent.pinchart+renesas@ideasonboard.com
Subject: Re: [PATCH 01/11] clocksource: arm_arch_timer: Rename arch_timer_probed to reflect behaviour
Date: Tue, 31 Mar 2015 09:14:52 +0200 [thread overview]
Message-ID: <20150331071452.GA9252@gmail.com> (raw)
In-Reply-To: <1427746633-9137-1-git-send-email-daniel.lezcano@linaro.org>
* Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> The arch_timer_probed function returns whether the given time doesn't
> need to be probed. This can be the case when the timer has been probed
> already, but also when it has no corresponding enabled node in DT.
>
> Rename the function to arch_timer_need_probe and invert its return value
> to better reflect the function's purpose and behaviour.
>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/clocksource/arm_arch_timer.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index a3025e7..50bb7f2 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -661,17 +661,17 @@ static const struct of_device_id arch_timer_mem_of_match[] __initconst = {
> };
>
> static bool __init
> -arch_timer_probed(int type, const struct of_device_id *matches)
> +arch_timer_need_probe(int type, const struct of_device_id *matches)
If we do a rename we might as well use valid English spelling such as
'arch_timer_needs_probing()'?
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-31 7:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 20:14 [GIT PULL] clockevents for 4.1 Daniel Lezcano
2015-03-30 20:17 ` [PATCH 01/11] clocksource: arm_arch_timer: Rename arch_timer_probed to reflect behaviour Daniel Lezcano
2015-03-30 20:17 ` [PATCH 02/11] clocksource: sun5i: Switch to request_irq Daniel Lezcano
2015-03-30 20:17 ` [PATCH 03/11] clocksource: sun5i: Use of_io_request_and_map Daniel Lezcano
2015-03-30 20:17 ` [PATCH 04/11] clocksource: sun5i: Remove sched_clock Daniel Lezcano
2015-03-30 20:17 ` [PATCH 05/11] clocksource: sun5i: Refactor the current code Daniel Lezcano
2015-03-30 20:17 ` [PATCH 06/11] clocksource: sun5i: Add clock notifiers Daniel Lezcano
2015-03-30 20:17 ` [PATCH 07/11] clocksource: at91: Make IO endian agnostic Daniel Lezcano
2015-03-31 7:23 ` [tip:timers/core] clocksource/drivers/at91: Fix IO endianness tip-bot for Ben Dooks
2015-03-30 20:17 ` [PATCH 08/11] clocksource: sun4i-timer: Only register a sched_clock on sun4i and sun5i Daniel Lezcano
2015-03-31 7:22 ` [tip:timers/core] clocksource/drivers/sun4i-timer: " tip-bot for Hans de Goede
2015-03-30 20:17 ` [PATCH 09/11] clocksource: tegra: Maintain CPU endianness Daniel Lezcano
2015-03-31 7:22 ` [tip:timers/core] clocksource/drivers/tegra: Fix IO endianness tip-bot for Dmitry Osipenko
2015-03-30 20:17 ` [PATCH 10/11] clocksource: dw_apb_timer_of: Make IO endian agnostic Daniel Lezcano
2015-03-31 7:22 ` [tip:timers/core] clocksource/drivers/dw_apb_timers_of: Fix IO endianness causing time jumps tip-bot for Ben Dooks
2015-03-30 20:17 ` [PATCH 11/11] clocksource: efm32: Use CLOCK_EVT_FEAT_PERIODIC for defining features Daniel Lezcano
2015-03-31 7:21 ` [tip:timers/core] clocksource/drivers/efm32: " tip-bot for Viresh Kumar
2015-03-31 7:14 ` Ingo Molnar [this message]
2015-03-31 14:14 ` [PATCH 01/11] clocksource: arm_arch_timer: Rename arch_timer_probed to reflect behaviour Laurent Pinchart
2015-03-31 15:49 ` Ingo Molnar
2015-03-31 7:17 ` [GIT PULL] clockevents for 4.1 Ingo Molnar
2015-03-31 9:37 ` Daniel Lezcano
2015-03-31 9:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331071452.GA9252@gmail.com \
--to=mingo@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=daniel.lezcano@linaro.org \
--cc=digetx@gmail.com \
--cc=hdegoede@redhat.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).