From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752785AbbCaHO7 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 Mar 2015 03:14:59 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:47598 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750926AbbCaHO5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 Mar 2015 03:14:57 -0400
Date: Tue, 31 Mar 2015 10:14:54 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eddie Kovsky <ewk@edkovsky.org>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        rickard_strandqvist@spectrumdigital.se, c@24.io,
        linux-kernel@vger.kernel.org, gdonald@gmail.com,
        koray.gulcu@ozu.edu.tr, cristina.opriceana@gmail.com
Subject: Re: [PATCH V2] Staging: rtl8192 Clean up function definition
Message-ID: <20150331071454.GE10964@mwanda>
References: <20150330230536.GA32257@athena>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150330230536.GA32257@athena>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote:
> Change function definition to static, move the function further up in
> the file, and delete the function prototype.
> 
> This fixes the following warning generated by sparse:
> 
> drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol
> 'rtl8192_update_ratr_table' was not declared. Should it be static?
> 

Someone already fixed the warning earlier but this this is still a nice
patch to have.

regards,
dan carpenter