From: Eric Wong <normalperson@yhbt.net>
To: Takashi Iwai <tiwai@suse.de>, Joe Turner <joe@oampo.co.uk>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Eric Wong <normalperson@yhbt.net>
Subject: [PATCH] ALSA: usb-audio: don't try to get Benchmark DAC1 sample rate
Date: Tue, 31 Mar 2015 07:34:05 +0000 [thread overview]
Message-ID: <20150331073405.GA5912@dcvr.yhbt.net> (raw)
Adding this quirk allows us to avoid the noisy
"cannot get freq at ep 0x1" message in dmesg output every time
playback starts.
This ought to affect other Benchmark DAC1 variations using the same
"Microchip Technology, Inc." chip as well, but I have only tested
with the "Pre" variant.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
Cc: Joe Turner <joe@oampo.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>
---
I also had another generic patch prepared before I noticed Joe's
quirk addition for the MS Lifecam HD-5000.
sound/usb/quirks.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 753a47d..9a28365 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1113,8 +1113,13 @@ void snd_usb_set_format_quirk(struct snd_usb_substream *subs,
bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
{
- /* MS Lifecam HD-5000 doesn't support reading the sample rate. */
- return chip->usb_id == USB_ID(0x045E, 0x076D);
+ /* devices which do not support reading the sample rate. */
+ switch (chip->usb_id) {
+ case USB_ID(0x045E, 0x076D): /* MS Lifecam HD-5000 */
+ case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
+ return true;
+ }
+ return false;
}
/* Marantz/Denon USB DACs need a vendor cmd to switch
--
EW
next reply other threads:[~2015-03-31 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 7:34 Eric Wong [this message]
2015-03-31 7:36 ` [RFC] ALSA: usb-audio: reduce "cannot get freq at ep" spew Eric Wong
2015-04-04 12:13 ` Takashi Iwai
2015-04-04 12:08 ` [PATCH] ALSA: usb-audio: don't try to get Benchmark DAC1 sample rate Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331073405.GA5912@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=alsa-devel@alsa-project.org \
--cc=joe@oampo.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).