From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbbCaIMM (ORCPT ); Tue, 31 Mar 2015 04:12:12 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49431 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751008AbbCaIMH (ORCPT ); Tue, 31 Mar 2015 04:12:07 -0400 Date: Tue, 31 Mar 2015 10:12:04 +0200 From: Alexandre Belloni To: Chanwoo Choi Cc: Krzysztof Kozlowski , Kukjin Kim , Alessandro Zummo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, Kyungmin Park Subject: Re: [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc Message-ID: <20150331081204.GH3849@piout.net> References: <1427728773-29065-1-git-send-email-k.kozlowski@samsung.com> <1427728773-29065-3-git-send-email-k.kozlowski@samsung.com> <5519DE76.4080803@samsung.com> <20150331003101.GG3849@piout.net> <5519EE93.70509@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5519EE93.70509@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/2015 at 09:47:15 +0900, Chanwoo Choi wrote : > > Are you absolutely sure that the exynos3250 IP is the same as the > > s3c6410 (I don't know much about the exynos family). The concern being > > that if at one point you have an errata on one or ther other, you will > > have to break the DT ABI by undoing this change. > > > > Note that I'm fine with it, I'm just asking. > > I'm sure about exynos3250 RTC is same with S3C6410 RTC. > There was little different about that pevious S3C6410 RTC > don't consider to control the 'rtc_src' clk. > > > But, Javier's patch[1] add the '.needs_src_clk' to control the > 'rtc_src' clk. After merged this patch, there is no different part between > Exynos3250 RTC and S3C6410 RTC. > > [1] 8792f7772f4f (drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data) > Yes, I saw that the software was handling both the same way, I was asking about the hardware side. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com