From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750909AbbCaHmn (ORCPT ); Tue, 31 Mar 2015 03:42:43 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:40160 "EHLO e06smtp11.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbbCaHmk (ORCPT ); Tue, 31 Mar 2015 03:42:40 -0400 Date: Tue, 31 Mar 2015 09:42:24 +0200 From: Michael Mueller To: Eric Blake Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Eduardo Habkost , Gleb Natapov , Alexander Graf , Christian Borntraeger , Daniel Hansel , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Richard Henderson , Andreas Faerber Subject: Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions Message-ID: <20150331094224.5975c242@bee> In-Reply-To: <5519B1D1.5060503@redhat.com> References: <1427725708-52100-1-git-send-email-mimu@linux.vnet.ibm.com> <1427725708-52100-13-git-send-email-mimu@linux.vnet.ibm.com> <5519B1D1.5060503@redhat.com> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15033107-0041-0000-0000-000003E77F5C Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t2V7gpE6024394 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Mon, 30 Mar 2015 14:28:01 -0600 Eric Blake wrote: > On 03/30/2015 08:28 AM, Michael Mueller wrote: > > The patch adds optional parameters to the QMP command query-cpu-definitions. > > Thus the signature of routine arch_query_cpu_definitions needs to be changed > > for the stub function and all target implementations: > > > > target-arm > > target-i386 > > target-ppc > > target-s390 > > > > Signed-off-by: Michael Mueller > > --- > > > +++ b/qapi-schema.json > > @@ -2532,21 +2532,31 @@ > > # > > # @name: the name of the CPU definition > > # > > +# @default: #optional defines if cpu model is the default (since 2.4) > > Reads poorly. How about: > > # @default: #optional true if cpu model is the default, omitted if false > (since 2.4) Yep, will change > > > > +# > > +# @runnable: #optional defines if cpu model is runnable (since 2.4) > > Similarly: > > # @runnable: #optional true if cpu model is runnable, omitted if false > (since 2.4) here as well > > > +# > > # Since: 1.2.0 > > ## > > { 'type': 'CpuDefinitionInfo', > > - 'data': { 'name': 'str' } } > > + 'data': { 'name': 'str', '*is-default': 'bool', '*runnable': 'bool' } } > > > > ## > > # @query-cpu-definitions: > > # > > # Return a list of supported virtual CPU definitions > > # > > +# @machine: #optional machine type (since 2.4) > > +# > > +# @accel: #optional accelerator id (since 2.4) > > Maybe mention that these two fields are for filtering results. I will add a comment as it is more than filtering, it is execution context information that allows to determine if a cpu model is runnable. Thanks a lot, Michael > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVGk/gAAoJELPcPLQSJsKQ9qcQAJiURTXS+NZO/kmKfP1aH18s RC/bhXyV6gVmfsvZ1X7S0cH5eO4Z7AfpNNT73Mw0lYDIXei+94/Mdby4AplF7S8q RoPVu9KxWXV6oM1nigEMvExt5n6BxIM3+/xvKt1Rkef4cx8qIRju+rCLNekmBd3E yJtSs3Oasft8LoG+4ZPEv26jC7uvHa04bp1nZslXhgUmbUJZzRtArRohp0JA0kfl BIzpFSKJEvGB/xwyj4bvfC4NQJ9nMtel6BhO04oxHgQNXmpaJK4vN5h7wi6PG2ac I7mKhC/nNFPUXvQUGQ91itWH/ir1fyim4Rjhtd2Pvpq19waEg2M+dHp2YKAqg1xd YrHpAQA/6MLqlBqrsqYzVS/LHz7juXP3u/sX5azdbZY8LPynAXqnSwqiNinvk2bA sc3NG/JwZnbtASFrjJEpmrudS29IXuNNycISzGwrL06pwgmrFaJkpyzD6gOkJfnh UByIMqTYskk3yP8G8K4n6775al0Zx8v39E7En+dQozEnVa/SxA5YdjJMVPOZiEt4 O/szkqCr5kcQHZJ/x42Sz0YFZ5QIidhMkX6jEqeak7q0Ow0awXgreuxXEmPYu6lG 5wHo6WP1h6tdogQnJGnyFXC5kWzp2iBYxVDP86/4aKLGyZViNPS1XDSjhd9NH4X/ 9IPbCIOJYwpZF9l5GeG/ =JAwu -----END PGP SIGNATURE----- {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I