From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org,
Steven Miao <realmz6@gmail.com>
Subject: Re: [PATCH 1/2] timer: Avoid waking up an idle-core by migrate running timer
Date: Tue, 31 Mar 2015 16:53:12 +0200 [thread overview]
Message-ID: <20150331145312.GI23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <80182e47a7103608d2ddab7f62c0c3dffc99fdcc.1427782893.git.viresh.kumar@linaro.org>
On Tue, Mar 31, 2015 at 12:25:16PM +0530, Viresh Kumar wrote:
> Cc: Steven Miao <realmz6@gmail.com>
> +#define TIMER_FLAG_MASK 0x7LU
So Steven, this will break compilation on blackfin because that makes
____cacheline_aligned a NOP while we assume it will generate
__attribute__((__aligned__(SMP_CACHE_BYTES))) with the further
assumption that SMP_CACHE_BYTES >= 8.
Can you explain why blackfin chooses to break ____cacheline_align for
UP? We have the *_in_smp variants to distinguish these cases.
next prev parent reply other threads:[~2015-03-31 14:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 6:55 [PATCH 0/2] timer: Migrate running timers Viresh Kumar
2015-03-31 6:55 ` [PATCH 1/2] timer: Avoid waking up an idle-core by migrate running timer Viresh Kumar
2015-03-31 14:53 ` Peter Zijlstra [this message]
2015-04-14 23:13 ` Thomas Gleixner
2015-04-17 8:12 ` viresh kumar
2015-04-17 8:32 ` Ingo Molnar
2015-04-21 21:32 ` Thomas Gleixner
2015-04-21 21:54 ` Eric Dumazet
2015-04-22 15:29 ` Peter Zijlstra
2015-04-22 16:02 ` Eric Dumazet
2015-04-22 18:56 ` Thomas Gleixner
2015-04-22 19:59 ` Eric Dumazet
2015-04-22 21:56 ` Thomas Gleixner
2015-04-23 6:57 ` Eric Dumazet
2015-04-23 12:45 ` Thomas Gleixner
2015-04-25 18:37 ` Eric Dumazet
2015-05-05 13:00 ` Thomas Gleixner
2015-05-06 16:33 ` Eric Dumazet
2015-04-15 15:54 ` Thomas Gleixner
2015-03-31 6:55 ` [PATCH 2/2] timer: Replace base-> 'running_timer' with 'busy' Viresh Kumar
2015-03-31 15:01 ` [PATCH 0/2] timer: Migrate running timers Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331145312.GI23123@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=realmz6@gmail.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).