From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754898AbbCaPtx (ORCPT ); Tue, 31 Mar 2015 11:49:53 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:36094 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752036AbbCaPtu (ORCPT ); Tue, 31 Mar 2015 11:49:50 -0400 Date: Tue, 31 Mar 2015 17:49:45 +0200 From: Ingo Molnar To: Laurent Pinchart Cc: Daniel Lezcano , tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maxime.ripard@free-electrons.com, viresh.kumar@linaro.org, ben.dooks@codethink.co.uk, digetx@gmail.com, hdegoede@redhat.com, laurent.pinchart+renesas@ideasonboard.com Subject: Re: [PATCH 01/11] clocksource: arm_arch_timer: Rename arch_timer_probed to reflect behaviour Message-ID: <20150331154945.GA27058@gmail.com> References: <5519AEB2.8050306@linaro.org> <1427746633-9137-1-git-send-email-daniel.lezcano@linaro.org> <20150331071452.GA9252@gmail.com> <15031814.pvNHsWnCPH@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15031814.pvNHsWnCPH@avalon> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Laurent Pinchart wrote: > Hi Ingo, > > On Tuesday 31 March 2015 09:14:52 Ingo Molnar wrote: > > * Daniel Lezcano wrote: > > > From: Laurent Pinchart > > > > > > The arch_timer_probed function returns whether the given time doesn't > > > need to be probed. This can be the case when the timer has been probed > > > already, but also when it has no corresponding enabled node in DT. > > > > > > Rename the function to arch_timer_need_probe and invert its return value > > > to better reflect the function's purpose and behaviour. > > > > > > Acked-by: Sudeep Holla > > > Signed-off-by: Laurent Pinchart > > > > > > Signed-off-by: Daniel Lezcano > > > --- > > > > > > drivers/clocksource/arm_arch_timer.c | 13 +++++++------ > > > 1 file changed, 7 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/clocksource/arm_arch_timer.c > > > b/drivers/clocksource/arm_arch_timer.c index a3025e7..50bb7f2 100644 > > > --- a/drivers/clocksource/arm_arch_timer.c > > > +++ b/drivers/clocksource/arm_arch_timer.c > > > @@ -661,17 +661,17 @@ static const struct of_device_id > > > arch_timer_mem_of_match[] __initconst = {> > > > }; > > > > > > static bool __init > > > > > > -arch_timer_probed(int type, const struct of_device_id *matches) > > > +arch_timer_need_probe(int type, const struct of_device_id *matches) > > > > If we do a rename we might as well use valid English spelling such as > > 'arch_timer_needs_probing()'? > > Of course. Should I resend the patch or can you fix that while applying it ? No need to resend, I've done the rename in the patch. Thanks, Ingo