From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbbCaTZT (ORCPT ); Tue, 31 Mar 2015 15:25:19 -0400 Received: from gproxy1-pub.mail.unifiedlayer.com ([69.89.25.95]:37395 "HELO gproxy1-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751413AbbCaTZP (ORCPT ); Tue, 31 Mar 2015 15:25:15 -0400 X-Authority-Analysis: v=2.1 cv=Juti8qIC c=1 sm=1 tr=0 a=PkLafpyMt2xwRD+PMJrZ3Q==:117 a=PkLafpyMt2xwRD+PMJrZ3Q==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=J0QyKEt1u0cA:10 a=kj9zAlcOel0A:10 a=ptNznvi-AAAA:8 a=fztpppUj2ZoA:10 a=Xwexni91U_8A:10 a=emO1SXQWCLwA:10 a=LOAqU9qh108vBw58OWAA:9 a=CjuIK1q_8ugA:10 Date: Tue, 31 Mar 2015 13:25:02 -0600 From: Eddie Kovsky To: Dan Carpenter Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, rickard_strandqvist@spectrumdigital.se, c@24.io, linux-kernel@vger.kernel.org, gdonald@gmail.com, koray.gulcu@ozu.edu.tr, cristina.opriceana@gmail.com Subject: Re: [PATCH V2] Staging: rtl8192 Clean up function definition Message-ID: <20150331192502.GA28390@athena> References: <20150330230536.GA32257@athena> <20150331071454.GE10964@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150331071454.GE10964@mwanda> User-Agent: Mutt/1.5.23 (2014-03-12) X-Identified-User: {1650:box492.bluehost.com:edkovsky:edkovsky.org} {sentby:smtp auth 65.102.196.57 authed with ewk+edkovsky.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote: > On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote: > > Change function definition to static, move the function further up in > > the file, and delete the function prototype. > > > > This fixes the following warning generated by sparse: > > > > drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol > > 'rtl8192_update_ratr_table' was not declared. Should it be static? > > > > Someone already fixed the warning earlier but this this is still a nice > patch to have. > > regards, > dan carpenter Dan I sent in the patch last week to fix this warning. You had asked me to clean up the function by removing the prototype instead. Greg had already sent me a message saying he picked up that patch. I waited a few cycles, but I still haven't seen my patch show up in yesterday's (or today's) next. I assume my original patch got dropped waiting on this one? Eddie