From: Peter Zijlstra <peterz@infradead.org>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yogesh Narayan Gaur <yn.gaur@samsung.com>,
AJEET YADAV <ajeet.y@samsung.com>, Tejun Heo <tj@kernel.org>
Subject: Re: Re: msgrcv: use freezable blocking call
Date: Wed, 1 Apr 2015 09:35:55 +0200 [thread overview]
Message-ID: <20150401073555.GT27490@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1685075594.210481427865525094.JavaMail.weblogic@epmlwas09b>
On Wed, Apr 01, 2015 at 05:18:46AM +0000, Maninder Singh wrote:
> Hi Andrew,
> Thanks for making new patch, Actually there is some problem with our mail editor.
> It changes tabs with spaces and corrupts the patch, we are solving the same at our end.
> Thats why i am sending you signed -off by only for both patches.
Sort it and resend, no real great hurry with these patches, right?
> 1. For msgrcv: use freezable blocking call
> Signed-off-by: Yogesh Gaur <yn.gaur@samsung.com>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com>
Did you really pass around that patch through 3 people or did it take
all three of you to modify those two lines?
Should some of those SoBs be a reviewed-by perhaps?
> ----> For Peter's Review comment:- This is what, no why mentioned
>
> This call was selected to be converted to a freezable call because
> it doesn't hold any locks or release any resources when interrupted
> that might be needed by another freezing task or a kernel driver
> during suspend, and is a common site where idle userspace tasks are
> blocked.
Please put such things in the Changelog so that we can see you've
thought about things.
next prev parent reply other threads:[~2015-04-01 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 5:18 Re: msgrcv: use freezable blocking call Maninder Singh
2015-04-01 7:35 ` Peter Zijlstra [this message]
2015-04-01 19:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401073555.GT27490@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ajeet.y@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=tj@kernel.org \
--cc=yn.gaur@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).