From: Jan Kara <jack@suse.cz>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Wei Yuan <weiyuan.wei@huawei.com>,
jack@suse.cz, akpm@linux-foundation.org,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, lizefan@huawei.com
Subject: Re: [PATCH] ext3: Remove useless condition in if statement.
Date: Wed, 1 Apr 2015 09:40:18 +0200 [thread overview]
Message-ID: <20150401074018.GA26339@quack.suse.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.1503231130060.1578@localhost.localdomain>
On Mon 23-03-15 11:30:44, Lukáš Czerner wrote:
> On Fri, 20 Mar 2015, Wei Yuan wrote:
>
> > Date: Fri, 20 Mar 2015 11:09:10 +0800
> > From: Wei Yuan <weiyuan.wei@huawei.com>
> > To: jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca
> > Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
> > lczerner@redhat.com, lizefan@huawei.com
> > Subject: [PATCH] ext3: Remove useless condition in if statement.
> >
> > In this if statement, the previous condition is useless, the later one has covered it.
>
> Nice that you've send this ext3 counterpart for ext4 patch. Thanks!
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Thanks. I've added the patch to my tree.
Honza
>
> >
> > Signed-off-by: Weiyuan <weiyuan.wei@huawei.com>
> > ---
> > fs/ext3/xattr.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c
> > index c6874be..24215dc 100644
> > --- a/fs/ext3/xattr.c
> > +++ b/fs/ext3/xattr.c
> > @@ -546,8 +546,7 @@ ext3_xattr_set_entry(struct ext3_xattr_info *i, struct ext3_xattr_search *s)
> > free += EXT3_XATTR_LEN(name_len);
> > }
> > if (i->value) {
> > - if (free < EXT3_XATTR_SIZE(i->value_len) ||
> > - free < EXT3_XATTR_LEN(name_len) +
> > + if (free < EXT3_XATTR_LEN(name_len) +
> > EXT3_XATTR_SIZE(i->value_len))
> > return -ENOSPC;
> > }
> >
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2015-04-01 7:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 3:09 [PATCH] ext3: Remove useless condition in if statement Wei Yuan
2015-03-23 10:30 ` Lukáš Czerner
2015-04-01 7:40 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401074018.GA26339@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=weiyuan.wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).