From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbbDAMTL (ORCPT ); Wed, 1 Apr 2015 08:19:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46862 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753321AbbDAMTI (ORCPT ); Wed, 1 Apr 2015 08:19:08 -0400 Date: Wed, 1 Apr 2015 14:18:53 +0200 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org, mingo@redhat.com, lizefan@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] perf tools: introduce machine_map_new to merge mmap/mmap2 processing code. Message-ID: <20150401121853.GB10820@krava.brq.redhat.com> References: <1427884395-241111-1-git-send-email-wangnan0@huawei.com> <1427884395-241111-3-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427884395-241111-3-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 01, 2015 at 10:33:13AM +0000, Wang Nan wrote: > Create a machine_map_new() and merge mapping code in > machine__process_mmap2_event() and machine__process_mmap_event() > together. This patch is a preparation for following map adjustment > patches. > > Signed-off-by: Wang Nan > --- > tools/perf/util/machine.c | 30 +++++++++++++++++++++--------- > 1 file changed, 21 insertions(+), 9 deletions(-) > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index e335330..051883a 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1155,13 +1155,29 @@ out_problem: > return -1; > } > > +static int machine_map_new(struct machine *machine, u64 start, u64 len, > + u64 pgoff, u32 pid, u32 d_maj, u32 d_min, u64 ino, > + u64 ino_gen, u32 prot, u32 flags, char *filename, > + enum map_type type, struct thread *thread) the name style for this should be more like 'machine__new_map' I think Arnaldo will chime in.. ;-) jirka