From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 1/6] virtio_balloon: transitional interface
Date: Wed, 1 Apr 2015 12:22:44 +0200 [thread overview]
Message-ID: <20150401122244.5a033ff5.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20150401113300-mutt-send-email-mst@redhat.com>
On Wed, 1 Apr 2015 11:43:46 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Apr 01, 2015 at 07:53:14PM +1030, Rusty Russell wrote:
> > "Michael S. Tsirkin" <mst@redhat.com> writes:
> > > On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell wrote:
> > >> I would leave the device *exactly* as is, ugly structure packing and
> > >> all.
> > >
> > > But why? It's going to be used for years, might as well make it clean?
> >
> > Because the only spec which currently exists says to do that.
>
> OK but the only spec which currently exists also says it's a legacy only
> device, so driver must not set VERSION_1. So surely, we can make minor
> changes when VERSION_1 is set, like we did for other devices.
But we don't plan to replace the other devices, so it makes sense to do
some changes for 1.0.
>
> Let me post the latest patches I'm working on,
> see what you think then.
>
> > We do
> > need a new virtio memballoon spec, but it'll look nothing like this
> > anyway.
> >
> > Cheers,
> > Rusty.
>
> I think it's going to have significantly different semantics, too,
> so not much value in making that one work with current
> drivers, right?
>
So why not just keep virtio-balloon as-is and just specify endianness
etc. for 1.0? Keeps the old drivers going without hacks, and we can
start with a fresh driver for the new virtio-balloon.
next prev parent reply other threads:[~2015-04-01 10:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 19:52 [PATCH v2 0/6] virtio_balloon: virtio 1 support Michael S. Tsirkin
2015-03-31 19:52 ` [PATCH v2 1/6] virtio_balloon: transitional interface Michael S. Tsirkin
2015-04-01 3:47 ` Rusty Russell
2015-04-01 7:44 ` Michael S. Tsirkin
2015-04-01 9:23 ` Rusty Russell
2015-04-01 9:43 ` Michael S. Tsirkin
2015-04-01 10:22 ` Cornelia Huck [this message]
2015-04-01 10:28 ` Michael S. Tsirkin
2015-04-01 10:57 ` Cornelia Huck
2015-04-01 13:00 ` Michael S. Tsirkin
2015-03-31 19:52 ` [PATCH v2 2/6] virtio: balloon might not be a legacy device Michael S. Tsirkin
2015-03-31 19:52 ` [PATCH v2 3/6] virtio_ccw: support non-legacy balloon devices Michael S. Tsirkin
2015-03-31 19:52 ` [PATCH v2 4/6] virtio_mmio: " Michael S. Tsirkin
2015-03-31 19:52 ` [PATCH v2 5/6] virtio_pci: " Michael S. Tsirkin
2015-03-31 19:52 ` [PATCH v2 6/6] virtio: drop virtio_device_is_legacy_only Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401122244.5a033ff5.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).