From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752666AbbDAVlY (ORCPT ); Wed, 1 Apr 2015 17:41:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36475 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751764AbbDAVlX (ORCPT ); Wed, 1 Apr 2015 17:41:23 -0400 Date: Wed, 1 Apr 2015 14:41:21 -0700 From: Andrew Morton To: Greg KH Cc: Daniel Mack , dh.herrmann@gmail.com, jslaby@suse.cz, tixxdz@opendz.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] samples: kdbus: build kdbus-workers conditionally Message-Id: <20150401144121.c1ae57c1d6ab5562a1fca766@linux-foundation.org> In-Reply-To: <20150401124720.GA22629@kroah.com> References: <5511A0D6.5030606@suse.cz> <1427807494-29982-1-git-send-email-daniel@zonque.org> <20150401124720.GA22629@kroah.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Apr 2015 14:47:20 +0200 Greg KH wrote: > On Tue, Mar 31, 2015 at 03:11:34PM +0200, Daniel Mack wrote: > > Give the kdbus sample its own config switch and only build it if it's > > explicitly switched on. > > > > Signed-off-by: Daniel Mack > > Reviewed-by: David Herrmann > > Reported-by: Jiri Slaby > > --- > > samples/Kconfig | 7 +++++++ > > samples/kdbus/Makefile | 2 +- > > 2 files changed, 8 insertions(+), 1 deletion(-) > > Now applied, thanks. Is this going to fix i386 allmodconfig, currently unhappy on my Fedora Core 6 (lol) machine? samples/kdbus/kdbus-workers.c:73:26: error: sys/signalfd.h: No such file or directory samples/kdbus/kdbus-workers.c: In function 'master_new': samples/kdbus/kdbus-workers.c:231: warning: implicit declaration of function 'signalfd' samples/kdbus/kdbus-workers.c:231: error: 'SFD_CLOEXEC' undeclared (first use in this function) samples/kdbus/kdbus-workers.c:231: error: (Each undeclared identifier is reported only once samples/kdbus/kdbus-workers.c:231: error: for each function it appears in.) samples/kdbus/kdbus-workers.c: In function 'master_handle_signal': samples/kdbus/kdbus-workers.c:406: error: storage size of 'val' isn't known samples/kdbus/kdbus-workers.c:406: warning: unused variable 'val' samples/kdbus/kdbus-workers.c: In function 'child_run': samples/kdbus/kdbus-workers.c:773: error: 'CLOCK_MONOTONIC_COARSE' undeclared (first use in this function) samples/kdbus/kdbus-workers.c: In function 'bus_open_connection': samples/kdbus/kdbus-workers.c:1038: error: 'O_CLOEXEC' undeclared (first use in this function) samples/kdbus/kdbus-workers.c: In function 'bus_make': samples/kdbus/kdbus-workers.c:1275: error: 'O_CLOEXEC' undeclared (first use in this function)