From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753222AbbDCAvh (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Apr 2015 20:51:37 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:42796 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753070AbbDCAvd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Apr 2015 20:51:33 -0400
Date: Thu, 02 Apr 2015 20:51:31 -0400 (EDT)
Message-Id: <20150402.205131.1699226515102250937.davem@davemloft.net>
To: stsp@list.ru
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        thomas.petazzoni@free-electrons.com, f.fainelli@gmail.com
Subject: Re: [PATCH] mvneta: implement SGMII-based in-band link state
 signaling
From: David Miller <davem@davemloft.net>
In-Reply-To: <551AA02B.2050104@list.ru>
References: <551AA02B.2050104@list.ru>
X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Apr 2015 17:51:33 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Stas Sergeev <stsp@list.ru>
Date: Tue, 31 Mar 2015 16:24:59 +0300

> @@ -2590,6 +2651,7 @@ static int mvneta_mdio_probe(struct mvneta_port *pp)
> 
>  static void mvneta_mdio_remove(struct mvneta_port *pp)
>  {
> +	fixed_phy_set_link_update(pp->phy_dev, NULL);

I do not see any other driver doing this on shutdown.
Please show me why it is necessary.

And if it is, all other drivers registering a fixed phy link update
function need to be adjusted to do the same thing.