From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbbDBDYQ (ORCPT ); Wed, 1 Apr 2015 23:24:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44364 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbbDBDYO (ORCPT ); Wed, 1 Apr 2015 23:24:14 -0400 Date: Thu, 2 Apr 2015 11:24:05 +0800 From: Dave Young To: Xishi Qiu Cc: x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, bhe@redhat.com, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, Tang Chen Subject: Re: [PATCH] x86/numa: kernel stack corruption fix Message-ID: <20150402032405.GB9218@dhcp-128-53.nay.redhat.com> References: <20150401045346.GA3461@dhcp-16-198.nay.redhat.com> <20150401051133.GC8680@dhcp-128-53.nay.redhat.com> <551CA08E.8060503@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551CA08E.8060503@huawei.com> User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Xishi [snip] > >> arch/x86/mm/numa.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> --- linux.orig/arch/x86/mm/numa.c > >> +++ linux/arch/x86/mm/numa.c > >> @@ -484,7 +484,8 @@ static void __init numa_clear_kernel_nod > >> > >> /* Mark all kernel nodes. */ > >> for_each_memblock(reserved, r) > >> - node_set(r->nid, numa_kernel_nodes); > > Hi Dave, > > How about add some comment here? if set numa=off, numa_meminfo may not include > all the memblock.reserved memory. e.g. trim_snb_memory() Sure, I can do that. I will send an update if there's no other comments. > >> + if (r->nid != MAX_NUMNODES) > >> + node_set(r->nid, numa_kernel_nodes); > >> > >> /* Clear MEMBLOCK_HOTPLUG flag for memory in kernel nodes. */ > >> for (i = 0; i < numa_meminfo.nr_blks; i++) { > >> > > > Thanks Dave >