From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752468AbbDBF62 (ORCPT ); Thu, 2 Apr 2015 01:58:28 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:33145 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbbDBF6O (ORCPT ); Thu, 2 Apr 2015 01:58:14 -0400 Date: Thu, 2 Apr 2015 14:58:24 +0900 From: Sergey Senozhatsky To: Dmitry Monakhov Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, axboe@kernel.dk, viro@zeniv.linux.org.uk, dm-devel@redhat.com Subject: Re: [PATCH 6/7] block/partitions: use block_device name vsprintf helper Message-ID: <20150402055824.GA548@swordfish> References: <1427817681-4494-1-git-send-email-dmonakhov@openvz.org> <1427817681-4494-7-git-send-email-dmonakhov@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427817681-4494-7-git-send-email-dmonakhov@openvz.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (03/31/15 20:01), Dmitry Monakhov wrote: [..] > if(be32_to_cpu(magic) != SGI_LABEL_MAGIC) { > - /*printk("Dev %s SGI disklabel: bad magic %08x\n", > - bdevname(bdev, b), be32_to_cpu(magic));*/ > + /*printk("Dev %pg SGI disklabel: bad magic %08x\n", > + bdev, be32_to_cpu(magic));*/ > [..] > p = label->partitions; > if (be16_to_cpu(label->magic) != SUN_LABEL_MAGIC) { > -/* printk(KERN_INFO "Dev %s Sun disklabel: bad magic %04x\n", > - bdevname(bdev, b), be16_to_cpu(label->magic)); */ > +/* printk(KERN_INFO "Dev %pg Sun disklabel: bad magic %04x\n", > + bdev, be16_to_cpu(label->magic)); */ > put_dev_sector(sect); may be entirely remove these commented out printk()-s? -ss