From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753013AbbDBHv6 (ORCPT ); Thu, 2 Apr 2015 03:51:58 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:36611 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbbDBHvz (ORCPT ); Thu, 2 Apr 2015 03:51:55 -0400 Date: Thu, 2 Apr 2015 09:51:51 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: John Stultz , lkml , Thomas Gleixner , Prarit Bhargava , Richard Cochran Subject: Re: [PATCH 21/21] time: Rework debugging variables so they aren't global Message-ID: <20150402075151.GA24591@gmail.com> References: <1427945681-29972-1-git-send-email-john.stultz@linaro.org> <1427945681-29972-22-git-send-email-john.stultz@linaro.org> <20150402074739.GP23123@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150402074739.GP23123@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Wed, Apr 01, 2015 at 08:34:41PM -0700, John Stultz wrote: > > Ingo suggested that the timekeeping debugging variables > > recently added should not be global, and should be tied > > to the timekeeper's read_base. > > But why? its the same hardware clock for both tkr's. Surely if one goes > funny the other will too. > > It doesn't make sense to duplicate this. Well, could it be moved to the timekeeper data structure? What I was opposed to was making it super-global, after all the (nice) effort we made to tidy up global data structures in this area. Thanks, Ingo