From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752913AbbDBImO (ORCPT ); Thu, 2 Apr 2015 04:42:14 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:44891 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751306AbbDBImL (ORCPT ); Thu, 2 Apr 2015 04:42:11 -0400 Date: Thu, 2 Apr 2015 10:41:56 +0200 From: Peter Zijlstra To: Ingo Molnar Cc: John Stultz , lkml , Thomas Gleixner , Prarit Bhargava , Richard Cochran Subject: Re: [PATCH 21/21] time: Rework debugging variables so they aren't global Message-ID: <20150402084156.GP24151@twins.programming.kicks-ass.net> References: <1427945681-29972-1-git-send-email-john.stultz@linaro.org> <1427945681-29972-22-git-send-email-john.stultz@linaro.org> <20150402074739.GP23123@twins.programming.kicks-ass.net> <20150402075151.GA24591@gmail.com> <20150402083647.GT23123@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150402083647.GT23123@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2015 at 10:36:47AM +0200, Peter Zijlstra wrote: > Sure, struct timekeeper would work, the debug code already references > the global tk_core to access that. While looking at that, the comment near tk_core says: /* * The most important data for readout fits into a single 64 byte * cache line. */ I feel that should be qualified somewhat, this is only true for MONOTONIC (ktime_get()), any other time base ends up on more lines.