From: Christoph Hellwig <hch@lst.de>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org, axboe@kernel.dk,
ross.zwisler@linux.intel.com
Subject: Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem
Date: Thu, 2 Apr 2015 11:30:37 +0200 [thread overview]
Message-ID: <20150402093037.GA14209@lst.de> (raw)
In-Reply-To: <551BFFD2.20608@plexistor.com>
On Wed, Apr 01, 2015 at 05:25:22PM +0300, Boaz Harrosh wrote:
> pfn = PFN_DOWN(ei->addr + ei->size);
>
> - switch (ei->type) {
> - case E820_RAM:
> - case E820_PRAM:
> - case E820_RESERVED_KERN:
> - break;
> - default:
> + if (ei->type != E820_RAM && ei->type != E820_RESERVED_KERN)
> register_nosave_region(PFN_UP(ei->addr), pfn);
> - }
I guess this makes sense - if the content is persistent already we don't need
to save it.
> - if (e820.map[i].type != E820_RESERVED || res->start < (1ULL<<20)) {
> - if (e820.map[i].type != E820_PRAM)
> - res->flags |= IORESOURCE_BUSY;
> + if (((e820.map[i].type != E820_RESERVED) &&
> + (e820.map[i].type != E820_PRAM)) ||
> + res->start < (1ULL<<20)) {
So now we also trigger for PRAM regions under 1ULL<<20, was that the
intentional change? Honestly I don't really understand this 1ULL<<20
magic here even for the existing case. Guess this is magic from the
old ISA PC days?
> + res->flags |= IORESOURCE_BUSY;
Guess this is the real change, and I'd love to understand why this
makes a difference for you. IORESOURCE_BUSY is checked almost never,
and is intented to mean it's a driver mapping.
next prev parent reply other threads:[~2015-04-02 9:30 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 7:12 another pmem variant V3 Christoph Hellwig
2015-04-01 7:12 ` [PATCH 1/2] x86: add support for the non-standard protected e820 type Christoph Hellwig
2015-04-01 14:25 ` [PATCH] SQUASHME: Fixes to e820 handling of pmem Boaz Harrosh
2015-04-02 9:30 ` Christoph Hellwig [this message]
2015-04-02 9:37 ` Ingo Molnar
2015-04-02 9:40 ` Christoph Hellwig
2015-04-02 11:18 ` Christoph Hellwig
2015-04-02 11:20 ` Boaz Harrosh
2015-04-02 12:31 ` [tip:x86/pmem] x86/mm: Add support for the non-standard protected e820 type tip-bot for Christoph Hellwig
2015-04-02 19:08 ` Andy Lutomirski
2015-04-02 19:13 ` Ingo Molnar
2015-04-02 19:51 ` Andy Lutomirski
2015-04-16 22:31 ` Andy Lutomirski
2015-04-17 0:55 ` Elliott, Robert (Server Storage)
2015-04-17 0:59 ` Andy Lutomirski
2015-04-02 20:28 ` Yinghai Lu
2015-04-02 20:23 ` [PATCH 1/2] x86: add " Yinghai Lu
2015-04-03 16:14 ` [Linux-nvdimm] " Toshi Kani
2015-04-03 17:12 ` Yinghai Lu
2015-04-03 20:54 ` Toshi Kani
2015-04-04 9:40 ` Ingo Molnar
2015-04-05 7:44 ` Yinghai Lu
2015-04-06 7:27 ` Ingo Molnar
2015-04-06 17:29 ` Toshi Kani
2015-04-06 18:26 ` Yinghai Lu
2015-04-06 18:23 ` Toshi Kani
2015-04-05 9:18 ` Boaz Harrosh
2015-04-05 20:06 ` Yinghai Lu
2015-04-06 7:16 ` Boaz Harrosh
2015-04-06 15:55 ` Christoph Hellwig
2015-04-01 7:12 ` [PATCH 2/2] pmem: add a driver for persistent memory Christoph Hellwig
2015-04-01 15:18 ` Boaz Harrosh
2015-04-02 9:32 ` Christoph Hellwig
2015-04-02 12:31 ` [tip:x86/pmem] drivers/block/pmem: Add " tip-bot for Ross Zwisler
2015-04-02 15:31 ` [PATCH] pmem: Add prints at module load and unload Boaz Harrosh
2015-04-02 15:39 ` [Linux-nvdimm] " Dan Williams
2015-04-02 15:47 ` Boaz Harrosh
2015-04-02 16:01 ` Dan Williams
2015-04-02 16:44 ` Christoph Hellwig
2015-04-05 8:50 ` Boaz Harrosh
2015-04-07 15:19 ` Christoph Hellwig
2015-04-07 15:34 ` Boaz Harrosh
2015-04-07 15:46 ` [PATCH A+B] " Boaz Harrosh
2015-04-07 15:47 ` [PATCH 1A] pmem: Add prints at pmem_probe/remove Boaz Harrosh
2015-04-07 15:47 ` [PATCH 1B] pmem: Add prints at module load and unload Boaz Harrosh
2015-04-13 9:05 ` [PATCH A+B] " Greg KH
2015-04-13 12:05 ` Boaz Harrosh
2015-04-13 12:36 ` Greg KH
2015-04-13 13:20 ` Boaz Harrosh
2015-04-13 13:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402093037.GA14209@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=boaz@plexistor.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).