From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004AbbDBKwU (ORCPT ); Thu, 2 Apr 2015 06:52:20 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:36504 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972AbbDBKwO (ORCPT ); Thu, 2 Apr 2015 06:52:14 -0400 Date: Thu, 2 Apr 2015 11:52:09 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mturquette@linaro.org, sboyd@codeaurora.org, kernel@stlinux.com, devicetree@vger.kernel.org Subject: Re: [STLinux Kernel] [PATCH 0/4] clk: Provide support for always-on clocks Message-ID: <20150402105209.GA9447@x1> References: <1425071674-16995-1-git-send-email-lee.jones@linaro.org> <20150402081210.GB3567@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150402081210.GB3567@griffinp-ThinkPad-X1-Carbon-2nd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Apr 2015, Peter Griffin wrote: > Hi Lee, > > On Fri, 27 Feb 2015, Lee Jones wrote: > > > Some hardware contains bunches of clocks which must never be > > turned off. If drivers a) fail to obtain a reference to any > > of these or b) give up a previously obtained reference > > during suspend, the common clk framework will attempt to > > disable them and a platform can fail irrecoverably as a > > result. Usually the only way to recover from these failures > > is to reboot. > > > > To avoid either of these two scenarios from catastrophically > > disabling an otherwise perfectly healthy running system, > > clocks can be identified as always-on using this property > > from inside a clocksource's node. The CLK_IGNORE_UNUSED > > flag will be applied to each clock instance named in this > > property, thus preventing them from being shut down by the > > framework. > > Great stuff. > > One minor comment is that assuming this works on stih407 and stih410 > to the extent that the platform can now boot without clk_ignore_unused > kenel parameter then you should have an additional patch to remove > clk_ignore_unused from the default bootargs in stih407-b2120.dts and > stih410-b2120.dts files. It's already on my TODO list: TODO: - Clock Domain - Once the clk domain driver has been accepted, remove early returns in SPI driver - Remove clk_ignore_unused from the DT files - Add LMI1 clk to STiH418 > Maxime - Is it possible for you to test this series on stih418-b2199 as > a well? As it could most likely also be removed from stih418-b2199.dts file > to, but neither Lee or myself have the hardware to test. Take a look at the third item on my TODO. :) Yes Maxime, if you can test the set once I've completed item 3, that would be splendid. > Apart from that, for the series: - > Acked-by: Peter Griffin Thanks Peter. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog