From: Jeff Layton <jeff.layton@primarydata.com>
To: Mark Salter <msalter@redhat.com>
Cc: Jeff Layton <jlayton@primarydata.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: userspace breakage in linux/nfsd/debug.h
Date: Thu, 2 Apr 2015 11:58:13 -0400 [thread overview]
Message-ID: <20150402115813.6abf5596@tlielax.poochiereds.net> (raw)
In-Reply-To: <1427985766.2973.11.camel@deneb.redhat.com>
On Thu, 02 Apr 2015 10:42:46 -0400
Mark Salter <msalter@redhat.com> wrote:
> This patch:
>
> commit f895b252d4edf66b2895fb5a7b17a638665f3e1f
> Author: Jeff Layton <jlayton@primarydata.com>
> Date: Mon Nov 17 16:58:04 2014 -0500
>
> sunrpc: eliminate RPC_DEBUG
>
> It's always set to whatever CONFIG_SUNRPC_DEBUG is, so just use that.
>
> Signed-off-by: Jeff Layton <jlayton@primarydata.com>
> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
>
> breaks userspace use of linux/nfsd/debug.h because of:
>
> diff --git a/include/uapi/linux/nfsd/debug.h b/include/uapi/linux/nfsd/debug.h
> index a6f453c..1fdc95b 100644
> --- a/include/uapi/linux/nfsd/debug.h
> +++ b/include/uapi/linux/nfsd/debug.h
> @@ -15,7 +15,7 @@
> * Enable debugging for nfsd.
> * Requires RPC_DEBUG.
> */
> -#ifdef RPC_DEBUG
> +#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
> # define NFSD_DEBUG 1
> #endif
>
> IS_ENABLED() is not available outside the kernel and causes a compile
> time failure:
>
> /usr/include/linux/nfsd/debug.h:18:15: error: missing binary operator before token "("
> #if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
>
>
>
Huh, ok. Probably the right solution is to just get rid of NFSD_DEBUG
and convert all of the "#ifdef NFSD_DEBUG" statements into
"#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)".
Then we can just remove that whole block from nfsd/debug.h altogether. Mike,
care to spin up a patch for that or shall I?
--
Jeff Layton <jeff.layton@primarydata.com>
next prev parent reply other threads:[~2015-04-02 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 14:42 userspace breakage in linux/nfsd/debug.h Mark Salter
2015-04-02 15:58 ` Jeff Layton [this message]
2015-04-02 17:53 ` Jeff Layton
2015-04-02 18:54 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402115813.6abf5596@tlielax.poochiereds.net \
--to=jeff.layton@primarydata.com \
--cc=jlayton@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).