From: Quentin Casasnovas <quentin.casasnovas@oracle.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Quentin Casasnovas <quentin.casasnovas@oracle.com>,
X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Oleg Nesterov <oleg@redhat.com>,
Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH] x86/xsave: Robustify and merge macros
Date: Thu, 2 Apr 2015 18:33:40 +0200 [thread overview]
Message-ID: <20150402163340.GB14902@chrystal.uk.oracle.com> (raw)
In-Reply-To: <20150402161259.GE3483@pd.tnic>
On Thu, Apr 02, 2015 at 06:12:59PM +0200, Borislav Petkov wrote:
> On Thu, Apr 02, 2015 at 05:52:10PM +0200, Quentin Casasnovas wrote:
> > FWIW I think this looks much nicer! I have a couple of comments though,
> > apologies in advance if they aren't relevant :)
>
> No worries, I very much appreciate the looking at. :)
>
:)
> > I thought the SYSTEM_BOOTING checks were present to make sure we call these
> > functions only when the alternative instructions had *not* been applied
> > (i.e. when SYSTEM_BOOTING). We could have added the opposite checks in
> > xsave_state()/xrstor_state() to make sure the alternative instructions are
> > applied when these are called (i.e. when !SYSTEM_BOOTING).
>
> Well, I think this was a clumsy way to say that we shouldn't be using
> the _booting() variants when the system isn't booting anymore:
>
> - WARN_ON(system_state != SYSTEM_BOOTING);
>
> - if (boot_cpu_has(X86_FEATURE_XSAVES))
> - asm volatile("1:"XSAVES"\n\t"
> - "2:\n\t"
> - xstate_fault
> - : "D" (fx), "m" (*fx), "a" (lmask), "d" (hmask)
> - : "memory");
> else
> - asm volatile("1:"XSAVE"\n\t"
> - "2:\n\t"
> - xstate_fault
> - : "D" (fx), "m" (*fx), "a" (lmask), "d" (hmask)
> - : "memory");
>
>
> WRT alternatives, the code didn't have any alternatives invocations
> there - it is just a cluttered way of saying:
>
> if (CPU has XSAVES support)
> XSAVES
> else
> XSAVE
So I'm not saying the function is using alternative, just that if the
alternative _are_ applied, then we do not want to use the *_booting()
variants (likely for performance reasons), hence the WARN_ON().
So IMO it does not hurt to keep it here, with maybe renaming it something
like the following so it is obvious why it's there:
/* Use the non _booting() variants if the alternatives are applied. */
WARN_ON(altinstr_are_applied());
I would personnaly add it to the non _booting() variants as well to make
sure the alternative instructions _are_ applied, since otherwise that would
probably cause random failures to restore the xsaveopt/xsaves context
previously saved. Obviously very paranoid check anyway so if you still
want to drop it then fine :)
Quentin
next prev parent reply other threads:[~2015-04-02 16:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 13:11 [PATCH] x86/xsave: Robustify and merge macros Borislav Petkov
2015-04-02 15:52 ` Quentin Casasnovas
2015-04-02 16:12 ` Borislav Petkov
2015-04-02 16:33 ` Quentin Casasnovas [this message]
2015-04-02 16:45 ` Borislav Petkov
2015-04-03 14:06 ` Quentin Casasnovas
2015-04-03 14:14 ` Quentin Casasnovas
2015-04-03 15:23 ` Borislav Petkov
2015-04-03 15:40 ` Quentin Casasnovas
2015-04-03 17:06 ` Borislav Petkov
2015-04-03 17:33 ` Quentin Casasnovas
2015-04-03 17:48 ` Borislav Petkov
2015-04-03 20:42 ` Quentin Casasnovas
2015-04-04 7:34 ` Borislav Petkov
2015-04-04 8:36 ` Quentin Casasnovas
2015-04-04 9:25 ` Borislav Petkov
2015-04-04 10:11 ` Quentin Casasnovas
2015-04-04 10:29 ` Borislav Petkov
2015-04-04 13:32 ` Borislav Petkov
2015-04-04 13:34 ` [PATCH] x86/alternatives: Fix ALTERNATIVE_2 padding generation properly Borislav Petkov
2015-04-07 9:27 ` Quentin Casasnovas
2015-04-07 9:40 ` [tip:x86/asm] " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402163340.GB14902@chrystal.uk.oracle.com \
--to=quentin.casasnovas@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).