From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753380AbbDCBXy (ORCPT ); Thu, 2 Apr 2015 21:23:54 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:37158 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbbDCBXw (ORCPT ); Thu, 2 Apr 2015 21:23:52 -0400 Date: Fri, 3 Apr 2015 09:23:35 +0800 From: joeyli To: rhn Cc: Pavel Machek , kernel list , joeyli.kernel@gmail.com, linux-pm@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: Unreliable hibernation on Lenovo x230 (regression) Message-ID: <20150403012335.GF2320@linux-rxt1.site> References: <20150401214743.20fbe2c5@porcupinefactory.org> <20150402152805.GA17021@amd> <20150402165054.GD2320@linux-rxt1.site> <20150402172221.GE2320@linux-rxt1.site> <20150402201200.1cf003f7@porcupinefactory.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150402201200.1cf003f7@porcupinefactory.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2015 at 08:12:00PM +0200, rhn wrote: > On Fri, 3 Apr 2015 01:22:21 +0800 > joeyli wrote: > > > On Fri, Apr 03, 2015 at 12:50:54AM +0800, joeyli wrote: > > > Hi, > > > > > > On Thu, Apr 02, 2015 at 05:28:05PM +0200, Pavel Machek wrote: > > > > On Wed 2015-04-01 21:47:43, rhn wrote: > > > > > Hello, > > > > > > > > > > Between kernel 3.16 and 3.17, a regression has been introduced where the first hibernation after regular shutdown always fails to resume. Subsequent hibernations succeed. > > > > > > > > > > The system is a Lenovo x230 with Intel i5, booting with EFI, with the hibernate partition located on a secondary SSD drive. Installed system is Fedora 20, hibernation and reboots were issued using the KDE shutdown dialog. > > > > > > > > > > I have tracked the problem to first appear in the commit > > > > > e67ee10190e69332f929bdd6594a312363321a66 Merge branches 'pm-sleep', 'pm-cpufreq' and 'pm-cpuidle' > > > > > > > > > > The problem itself manifests in dmesg as follows (system was first > > > > > restarted, then hibernated - this log is from the subsequent > > > > resume): > > > > > > > > Ok, can you try to disable cpufreq and cpuidle, and then try if it > > > > reproduces? > > > > > > > > At that point, this is the candidate: > > > > > > > > commit e67ee10190e69332f929bdd6594a312363321a66 > > > > Merge: 21c806d 84c91b7 39c8bba 372ba8c > > > > Author: Rafael J. Wysocki > > > > Date: Mon Aug 11 23:19:48 2014 +0200 > > > > > > > > Merge branches 'pm-sleep', 'pm-cpufreq' and 'pm-cpuidle' > > > > > > > > * pm-sleep: > > > > PM / hibernate: avoid unsafe pages in e820 reserved regions > > > > > > > > ... > > > > Alternatively, you can just try to revert > > > > > > > > commit 84c91b7ae07c62cf6dee7fde3277f4be21331f85 > > > > Author: Lee, Chun-Yi > > > > Date: Mon Aug 4 23:23:21 2014 +0800 > > > > > > > > PM / hibernate: avoid unsafe pages in e820 reserved regions > > > > > > > > When the machine doesn't well handle the e820 persistent when > > > > hibernate > > > > resuming, then it may cause page fault when writing image to > > > > snapshot > > > > buffer: > > > > > > > > > > > > ... > > > > > > > > Thanks, > > > > Pavel > > > > > > Before revert 84c91b7ae patch, please check does there have log similar as > > > following in dmesg when hibernate resume fail? > > > > > > [ 24.349777] PM: 0xab9bc000 in e820 nosave region: [mem 0xab9bc000-0xab9c2fff] > > > > > > The address may different, by you should see "e820 nosave region" log. Otherwise > > > we got another problem. > > > > > > > Forgot to mention, please add "debug no_console_suspend=1 loglevel=9" to kernel > > parameter then try to reproduce issue and look at dmesg. > > > > > > Thanks a lot! > > Joey Lee > > Yes, it's present in dmesg when hibernate fails (default kernel params): > [ 3.138824] PM: 0x9d3d3000 in e820 nosave region: [mem 0x9d3d3000-0x9d3d3fff] > OK, then the message means 0x9d3d3000 address used by image kernel but in e820 region of current boot. Need check does this e820 region used by setup_data so reserved as E820_RESERVED_KERN. Need your complete dmesg to verify the e820 table. If the above assumption is true, then Yinghai Lu's patchset could fix this problem: x86: Kill E820_RESERVED_KERN https://lkml.org/lkml/2015/3/4/434 The target kernel version to merge his patches is v4.1 > I probably didn't make it clear - the top dmesg in my original message was from failed resume. > > Cheers, > rhn On the other hand, Could you please check you are using platform mode to turn off machine for hibernating? $ cat /sys/power/disk [platform] shutdown reboot suspend And, if possible, please file bug on bugzilla.kernel.org and give me the bug number. I prefer collect log and debugging history in bugzilla for further tracking. Thanks a lot! Joey Lee