From: Dave Young <dyoung@redhat.com>
To: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>,
x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de,
bhe@redhat.com, mingo@redhat.com, hpa@zytor.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] x86/numa: kernel stack corruption fix
Date: Fri, 3 Apr 2015 15:03:47 +0800 [thread overview]
Message-ID: <20150403070347.GB22579@dhcp-128-53.nay.redhat.com> (raw)
In-Reply-To: <551d9535.87628c0a.5324.7358@mx.google.com>
> > > >>
> > > >> The above reserved region includes 0x40004000, a page excluded in
> > > >> trim_snb_memory. For this memblock reserved region the nid is not set it is
> > > >> still default value MAX_NUMNODES. later node_set callback will set bit
> > > >> MAX_NUMNODES in nodemask bitmap thus stack corruption happen.
> > > >>
> > >
> > > Hi Dave,
> > >
> > > Is it means, first reserved region 0x40000000 - 0x40100000, then boot the kdump
> > > kernel, so this region is not include in "numa_meminfo", and memblock.reserved
> > > (0x40004000) is still MAX_NUMNODES from trim_snb_memory().
> >
> > Right, btw, I booted kdump kernel with numa=off for saving memory.
> >
> > I suspect it will also be reproduced with mem=XYZ with normal kernel.
>
> Does the issue occur on your system with mem=0x40000000?
>
> I think the issue occurs when reserved memory range is not includes
> in system ram which informed by e820 or SRAT table. On your system,
> 0x40004000 is reserved by trim_snb_memory(). But if you use mem=0x40000000,
> the system ram is limited within 0x40000000. So the issue will occur.
It does occur with mem=800M during my previous test, I think it will occur with
mem=0x40000000 as well though I did not test mem=0x40000000.
Thanks
Dave
next prev parent reply other threads:[~2015-04-03 7:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 4:53 [PATCH] x86/numa: kernel stack corruption fix Dave Young
2015-04-01 5:11 ` Dave Young
2015-04-01 7:27 ` Xishi Qiu
2015-04-01 7:41 ` Dave Young
2015-04-01 8:21 ` Xishi Qiu
2015-04-01 8:34 ` Xishi Qiu
2015-04-01 9:17 ` Dave Young
2015-04-01 9:33 ` Xishi Qiu
2015-04-02 19:15 ` Yasuaki Ishimatsu
2015-04-03 7:03 ` Dave Young [this message]
2015-04-02 1:51 ` Xishi Qiu
2015-04-02 3:24 ` Dave Young
2015-04-02 19:36 ` Yasuaki Ishimatsu
2015-04-03 7:15 ` Dave Young
2015-04-03 7:17 ` Ingo Molnar
2015-04-03 7:23 ` Dave Young
2015-04-06 14:26 ` Yasuaki Ishimatsu
2015-04-07 3:33 ` Dave Young
2015-04-07 14:15 ` Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403070347.GB22579@dhcp-128-53.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qiuxishi@huawei.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).