From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753018AbbDCOqn (ORCPT ); Fri, 3 Apr 2015 10:46:43 -0400 Received: from aso-006-i442.relay.mailchannels.net ([23.91.64.123]:20345 "EHLO relay.mailchannels.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752445AbbDCOqk (ORCPT ); Fri, 3 Apr 2015 10:46:40 -0400 X-Sender-Id: duocircle|x-authuser|jac299792458 X-Sender-Id: duocircle|x-authuser|jac299792458 X-MC-Relay: Neutral X-MailChannels-SenderId: duocircle|x-authuser|jac299792458 X-MailChannels-Auth-Id: duocircle X-MC-Loop-Signature: 1428072396354:3298264739 X-MC-Ingress-Time: 1428072396354 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 72.84.113.125 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX19/4vw8y0u0bjVS83HUVA6ZWpIoT2MpVRE= X-DKIM: OpenDKIM Filter v2.6.8 io 7464A80012 Date: Fri, 3 Apr 2015 14:46:24 +0000 From: Jason Cooper To: Zhen Lei Cc: Thomas Gleixner , Marc Zyngier , linux-kernel , Zefan Li , Xinwei Hu , Tianhong Ding , Kefeng Wang , Yun Wu Subject: Re: [PATCH 1/1] irqchip/gicv3-its: remove GITS_BASER_TYPE_CPU base on latest specification Message-ID: <20150403144624.GM24598@io.lakedaemon.net> References: <1428032032-11128-1-git-send-email-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428032032-11128-1-git-send-email-thunder.leizhen@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-AuthUser: jac299792458 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Zhen Lei, On Fri, Apr 03, 2015 at 11:33:52AM +0800, Zhen Lei wrote: > Acutally, "Interrupt Collections" and "Physical Processors" is the > same thing. I'm sorry, but this isn't clear. > Signed-off-by: Zhen Lei > --- > drivers/irqchip/irq-gic-v3-its.c | 2 +- > include/linux/irqchip/arm-gic-v3.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 9687f8a..a795aae 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -777,7 +777,7 @@ static int __init its_alloc_lpi_tables(void) > static const char *its_base_type_string[] = { > [GITS_BASER_TYPE_DEVICE] = "Devices", > [GITS_BASER_TYPE_VCPU] = "Virtual CPUs", > - [GITS_BASER_TYPE_CPU] = "Physical CPUs", > + [GITS_BASER_TYPE_RESERVED3] = "Reserved (3)", Are you fixing a bug? Was the old information wrong? Did the spec get revised? Please redo your commit message to explain why this change is necessary and what it's doing. > [GITS_BASER_TYPE_COLLECTION] = "Interrupt Collections", > [GITS_BASER_TYPE_RESERVED5] = "Reserved (5)", > [GITS_BASER_TYPE_RESERVED6] = "Reserved (6)", > diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h > index ffbc034..67f5779 100644 > --- a/include/linux/irqchip/arm-gic-v3.h > +++ b/include/linux/irqchip/arm-gic-v3.h > @@ -233,7 +233,7 @@ > #define GITS_BASER_TYPE_NONE 0 > #define GITS_BASER_TYPE_DEVICE 1 > #define GITS_BASER_TYPE_VCPU 2 > -#define GITS_BASER_TYPE_CPU 3 > +#define GITS_BASER_TYPE_RESERVED3 3 > #define GITS_BASER_TYPE_COLLECTION 4 > #define GITS_BASER_TYPE_RESERVED5 5 > #define GITS_BASER_TYPE_RESERVED6 6 > -- > 1.8.0 thx, Jason.