From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbbDEBlz (ORCPT ); Sat, 4 Apr 2015 21:41:55 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34282 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbbDEBlx (ORCPT ); Sat, 4 Apr 2015 21:41:53 -0400 Date: Sun, 5 Apr 2015 07:11:47 +0530 From: Amitoj Kaur Chawla To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation Message-ID: <20150405014147.GA9738@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Removes extra parentheses around bitwise right shift operation. The issue was detected using the following coccinelle script. @@ expression e, e1; constant c; @@ e = -(e1 +e1 << -c); +c; @@ identifier i; constant c; type t; expression e; @@ t i = -(e +e << -c); +c; @@ expression e, e1; identifier f; constant c; @@ e1 = f(..., -(e +e << -c) +c ,...); Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/sm750fb/sm750.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 4074375..626b841 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -737,7 +737,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par) output->paths = sm750_crt; crtc->channel = sm750_secondary; /* not consider of padding stuffs for oScreen,need fix*/ - crtc->oScreen = (share->vidmem_size >> 1); + crtc->oScreen = share->vidmem_size >> 1; crtc->vScreen = share->pvMem + crtc->oScreen; } break; @@ -751,7 +751,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par) output->paths = sm750_crt; crtc->channel = sm750_primary; /* not consider of padding stuffs for oScreen,need fix*/ - crtc->oScreen = (share->vidmem_size >> 1); + crtc->oScreen = share->vidmem_size >> 1; crtc->vScreen = share->pvMem + crtc->oScreen; } break; -- 1.9.1