From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753113AbbDFJcM (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Apr 2015 05:32:12 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:49930 "EHLO
	relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752773AbbDFJcI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Apr 2015 05:32:08 -0400
X-Originating-IP: 50.43.43.179
Date: Mon, 6 Apr 2015 02:31:56 -0700
From: Josh Triplett <josh@joshtriplett.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Kees Cook <keescook@chromium.org>, Oleg Nesterov <oleg@redhat.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Rik van Riel <riel@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Michael Kerrisk <mtk.manpages@gmail.com>,
        Thiago Macieira <thiago.macieira@intel.com>,
        linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 7/7] clone4: Add a CLONE_FD flag to get task exit
 notification via fd
Message-ID: <20150406093154.GA22180@x>
References: <cover.1426376419.git.josh@joshtriplett.org>
 <fdec4b70c7cd34e2eacf6a0e41d36f606a696da1.1426376419.git.josh@joshtriplett.org>
 <20150406083035.GA16373@swordfish>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150406083035.GA16373@swordfish>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 06, 2015 at 05:30:35PM +0900, Sergey Senozhatsky wrote:
> On (03/15/15 01:00), Josh Triplett wrote:
> [..]
> > +
> > +/* Handle the CLONE_FD case for copy_process. */
> > +int clonefd_do_clone(u64 clone_flags, struct task_struct *p,
> > +		     struct clone4_args *args, struct clonefd_setup *setup)
> > +{
> > +	int flags;
> > +	struct file *file;
> > +	int fd;
> > +
> > +	p->clonefd = !!(clone_flags & CLONE_FD);
> > +	if (!p->clonefd)
> > +		return 0;
> > +
> > +	if (args->clonefd_flags & ~(O_CLOEXEC | O_NONBLOCK))
> > +		return -EINVAL;
> > +
> > +	init_waitqueue_head(&p->clonefd_wqh);
> > +
> > +	get_task_struct(p);
> > +	flags = O_RDONLY | FMODE_ATOMIC_POS | args->clonefd_flags;
> > +	file = anon_inode_getfile("[process]", &clonefd_fops, p, flags);
> > +	if (IS_ERR(file)) {
> > +		put_task_struct(p);
> > +		return PTR_ERR(file);
> > +	}
> > +
> > +	fd = get_unused_fd_flags(flags);
> > +	if (fd < 0) {
> 
> +		put_task_struct(p); ?

No, once anon_inode_getfile has succeeded, the file owns the reference
to the task_struct, so fput(file) will call the release function which
calls put_task_struct.  Only the failure case for anon_inode_getfile
needs to call put_task_struct directly.

> > +		fput(file);
> > +		return fd;
> > +	}

- Josh Triplett