From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753200AbbDFSkq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Apr 2015 14:40:46 -0400
Received: from mga11.intel.com ([192.55.52.93]:45566 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753120AbbDFSko (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Apr 2015 14:40:44 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,533,1422950400"; 
   d="scan'208";a="551707699"
Date: Mon, 6 Apr 2015 11:39:50 -0700
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: IIO <linux-iio@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Lee Jones <lee.jones@linaro.org>, Lars-Peter Clausen <lars@metafoo.de>,
        Hartmut Knaack <knaack.h@gmx.de>, Aaron Lu <aaron.lu@intel.com>,
        Todd Brandt <todd.e.brandt@linux.intel.com>
Subject: Re: [PATCH] iio/axp288_adc: add missing channel info mask
Message-ID: <20150406113950.3ebfa694@icelake>
In-Reply-To: <550D5EE7.20208@kernel.org>
References: <1426527265-14979-1-git-send-email-jacob.jun.pan@linux.intel.com>
	<550D5EE7.20208@kernel.org>
Organization: OTC
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 21 Mar 2015 12:07:03 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> > -		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED),
> > +		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED)
> > +		| BIT(IIO_CHAN_INFO_RAW),
> >  	},  
> These cases strike me as problematic.  You should not need both.  If
> the consumer is reading _raw from a channel that only supplies
> PROCESSED then that is the bug, not the lack of support for a raw
> read.
> >  };
Very sorry about the delay, you are right that we should just need RAW.
V2 patch just sent.

Thanks,

Jacob