From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753334AbbDFPxU (ORCPT ); Mon, 6 Apr 2015 11:53:20 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:36713 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785AbbDFPxT (ORCPT ); Mon, 6 Apr 2015 11:53:19 -0400 Date: Mon, 6 Apr 2015 11:53:15 -0400 From: Tejun Heo To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Christoph Lameter , Kevin Hilman , Mike Galbraith , "Paul E. McKenney" , Viresh Kumar , Frederic Weisbecker Subject: Re: [PATCH 4/4 V6] workqueue: Allow modifying low level unbound workqueue cpumask Message-ID: <20150406155315.GD10582@htj.duckdns.org> References: <1426653617-3240-1-git-send-email-laijs@cn.fujitsu.com> <1427973282-3052-1-git-send-email-laijs@cn.fujitsu.com> <1427973282-3052-5-git-send-email-laijs@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427973282-3052-5-git-send-email-laijs@cn.fujitsu.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2015 at 07:14:42PM +0800, Lai Jiangshan wrote: > /* make a copy of @attrs and sanitize it */ > copy_workqueue_attrs(new_attrs, attrs); > - cpumask_and(new_attrs->cpumask, new_attrs->cpumask, wq_unbound_global_cpumask); > + copy_workqueue_attrs(pwq_attrs, attrs); > + cpumask_and(new_attrs->cpumask, new_attrs->cpumask, cpu_possible_mask); > + cpumask_and(pwq_attrs->cpumask, pwq_attrs->cpumask, unbound_cpumask); Hmmm... why do we need to keep track of both cpu_possible_mask and unbound_cpumask? Can't we just make unbound_cpumask replace cpu_possible_mask for unbound workqueues? Thanks. -- tejun