From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbbDFQUH (ORCPT ); Mon, 6 Apr 2015 12:20:07 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52153 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752687AbbDFQUE (ORCPT ); Mon, 6 Apr 2015 12:20:04 -0400 Date: Mon, 6 Apr 2015 17:19:39 +0100 From: Mark Brown To: Lori Hikichi Cc: Scott Branden , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Dmitry Torokhov , Anatol Pomazao , abrestic@google.com, bryeung@google.com, olofj@google.com, pwestin@google.com Message-ID: <20150406161939.GJ6023@sirena.org.uk> References: <1427771784-29950-1-git-send-email-sbranden@broadcom.com> <1427771784-29950-3-git-send-email-sbranden@broadcom.com> <20150331064209.GD2869@sirena.org.uk> <551D8EB6.1050004@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6xTM0kUsJcaNctaW" Content-Disposition: inline In-Reply-To: <551D8EB6.1050004@broadcom.com> X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] ASoC: add core audio driver for Broadcom Cygnus SOC. X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6xTM0kUsJcaNctaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 02, 2015 at 11:47:18AM -0700, Lori Hikichi wrote: > On 15-03-30 11:42 PM, Mark Brown wrote: > >>+config SND_SOC_CYGNUS > >>+ tristate "SoC platform audio for Broadcom Cygnus chips" > >>+ depends on ARCH_BCM_CYGNUS || COMPILE_TEST > >>+ default ARCH_BCM_CYGNUS > Okay. You don't need to reply to every single comment, the general assumption will be that if there's no other followup all review comments will be addressed. It's better to just reply to things where there's something more detailed to say, if you explicitly reply to everything then that makes it easier for actual replies to be missed since there's a lot of there's a lot of the mail that's just going to be skipped through. > >>+static void ringbuf_inc(void __iomem *audio_io, bool is_playback, > >>+ const struct ringbuf_regs *p_rbuf) > >So it looks like we're getting an interrupt per period and we have to > >manually advance to the next one? > Yes. OK, so that seems fragile - what happens if we're slightly late processing an interrupt or miss one entirely? Most hardware has some way to read back the current position which tends to be more reliable, is that not an option here? --6xTM0kUsJcaNctaW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVIrIaAAoJECTWi3JdVIfQiAYH+wVe4O1UcpvFO9F0GnMCsFnF wJAziQ23f2t2CPa70+UbIMHo5a+EBrAYVWu+GbMPTkFeDwEiWC6baE2nVH9YK7Se O8zHqXBRdDvqiRgdRd/VJ3o8K/8uCtHV7Lj7Bi0g8A+vEpl8kBNOyGgvMHH4LDmS QwnkFF+2LmItLyP0IzcnpaQEWhqNx7EvEF3hfz+vLVF8t1Fc/m1/rGyxGWQ0oAwY BxnypCyvZJMRroMQMt85BSsr4n37J0Q8GKh9dnXAmYzbmmCDdZo8Mw2l2TDxVO5D PZkRw2f0OecdU1OqSO+F/jNJl8lU1PapcaARfb1NNADqLCyRlEz42Phior7P5Lc= =Ayjf -----END PGP SIGNATURE----- --6xTM0kUsJcaNctaW--