From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752965AbbDFSY3 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Apr 2015 14:24:29 -0400
Received: from mail-ig0-f180.google.com ([209.85.213.180]:35356 "EHLO
	mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752687AbbDFSY0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Apr 2015 14:24:26 -0400
Date: Mon, 6 Apr 2015 11:24:21 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: tps65010: remove incorrect __exit markups
Message-ID: <20150406182421.GA36776@dtor-ws>
References: <20150309174715.GA21698@dtor-ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150309174715.GA21698@dtor-ws>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lee,

On Mon, Mar 09, 2015 at 10:47:15AM -0700, Dmitry Torokhov wrote:
> Even if bus is not hot-pluggable, the devices can be unbound from the
> driver via sysfs, so we should not be using __exit annotations on
> remove() methods. The only exception is drivers registered with
> platform_driver_probe() which specifically disables sysfs bind/unbind
> attributes.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

*ping*

Thanks.

> ---
>  drivers/mfd/tps65010.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c
> index 743fb52..448f0a1 100644
> --- a/drivers/mfd/tps65010.c
> +++ b/drivers/mfd/tps65010.c
> @@ -515,7 +515,7 @@ static int tps65010_gpio_get(struct gpio_chip *chip, unsigned offset)
>  
>  static struct tps65010 *the_tps;
>  
> -static int __exit tps65010_remove(struct i2c_client *client)
> +static int tps65010_remove(struct i2c_client *client)
>  {
>  	struct tps65010		*tps = i2c_get_clientdata(client);
>  	struct tps65010_board	*board = dev_get_platdata(&client->dev);
> @@ -684,7 +684,7 @@ static struct i2c_driver tps65010_driver = {
>  		.name	= "tps65010",
>  	},
>  	.probe	= tps65010_probe,
> -	.remove	= __exit_p(tps65010_remove),
> +	.remove	= tps65010_remove,
>  	.id_table = tps65010_id,
>  };
>  
> -- 
> 2.2.0.rc0.207.ga3a616c
> 
> 
> -- 
> Dmitry

-- 
Dmitry