From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752884AbbDFTpG (ORCPT ); Mon, 6 Apr 2015 15:45:06 -0400 Received: from rhlx01.hs-esslingen.de ([129.143.116.10]:34521 "EHLO rhlx01.hs-esslingen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683AbbDFTpE (ORCPT ); Mon, 6 Apr 2015 15:45:04 -0400 X-Greylist: delayed 592 seconds by postgrey-1.27 at vger.kernel.org; Mon, 06 Apr 2015 15:45:03 EDT Date: Mon, 6 Apr 2015 21:35:09 +0200 From: Andreas Mohr To: Alexander Kuleshov Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Alexander Kuleshov Subject: Re: [PATCH] x86/boot: use __noreturn instead of directly __attribute__ definition Message-ID: <20150406193509.GA4476@rhlx01.hs-esslingen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428311077-32198-1-git-send-email-kuleshovmail@gmail.com> X-Priority: none User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > We no need to include to the arch/x86/boot/boot.h, > because boot.h already includes "bitops.h" which already includes > . "Depends", I'd say (no pun, and intended :). This currently implicitly working constellation might break both for: - boot.h no longer requiring bitops.h - bitops.h no longer including linux/compiler.h IMHO explicitly #include:ing parts which certain code does actively depend on after all is both a "code honesty" and a documentation issue ("Hmm, which interfaces does this implementation depend on? Ah, yeah...") Food for thought, Andreas Mohr P.S.: thanks for your contribution! -- GNU/Linux. It's not the software that's free, it's you.