From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
Kevin Hilman <khilman@linaro.org>,
Mike Galbraith <bitbucket@online.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 4/4 V6] workqueue: Allow modifying low level unbound workqueue cpumask
Date: Mon, 6 Apr 2015 21:58:17 -0400 [thread overview]
Message-ID: <20150407015817.GJ10582@htj.duckdns.org> (raw)
In-Reply-To: <55233227.9090701@cn.fujitsu.com>
Hello, Lai.
On Tue, Apr 07, 2015 at 09:25:59AM +0800, Lai Jiangshan wrote:
> On 04/06/2015 11:53 PM, Tejun Heo wrote:
> > On Thu, Apr 02, 2015 at 07:14:42PM +0800, Lai Jiangshan wrote:
> >> /* make a copy of @attrs and sanitize it */
> >> copy_workqueue_attrs(new_attrs, attrs);
> >> - cpumask_and(new_attrs->cpumask, new_attrs->cpumask, wq_unbound_global_cpumask);
> >> + copy_workqueue_attrs(pwq_attrs, attrs);
> >> + cpumask_and(new_attrs->cpumask, new_attrs->cpumask, cpu_possible_mask);
> >> + cpumask_and(pwq_attrs->cpumask, pwq_attrs->cpumask, unbound_cpumask);
> >
> > Hmmm... why do we need to keep track of both cpu_possible_mask and
> > unbound_cpumask? Can't we just make unbound_cpumask replace
> > cpu_possible_mask for unbound workqueues?
> >
>
> I want to save the original user-setting cpumask.
>
> When any time the wq_unbound_global_cpumask is changed,
> the new effective cpumask is
> the-original-user-setting-cpumask & wq_unbound_global_cpumask
> instead of
> the-last-effective-cpumask & wq_unbound_global_cpumask.
Yes, I get that, but that'd require just tracking the original
configured value and the unbound_cpumask masked value, no? What am I
missing?
Thanks.
--
tejun
next prev parent reply other threads:[~2015-04-07 1:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 5:00 [PATCH 0/4] workqueue: Introduce low-level unbound wq sysfs cpumask v4 Lai Jiangshan
2015-03-12 5:00 ` [PATCH 1/4] workqueue: Reorder sysfs code Lai Jiangshan
2015-03-12 5:00 ` [PATCH 2/4] workqueue: split apply_workqueue_attrs() into 3 stages Lai Jiangshan
2015-03-12 5:00 ` [PATCH 3/4] workqueue: Create low-level unbound workqueues cpumask Lai Jiangshan
2015-03-12 17:33 ` Christoph Lameter
2015-03-13 23:49 ` Kevin Hilman
2015-03-14 0:52 ` Kevin Hilman
2015-03-14 7:52 ` Lai Jiangshan
2015-03-16 17:12 ` Kevin Hilman
2015-03-16 17:25 ` Frederic Weisbecker
2015-03-16 19:38 ` Kevin Hilman
2015-03-12 5:00 ` [PATCH 4/4] workqueue: Allow modifying low level unbound workqueue cpumask Lai Jiangshan
2015-03-12 17:42 ` Christoph Lameter
2015-03-13 1:38 ` Lai Jiangshan
2015-03-13 7:49 ` Lai Jiangshan
2015-03-12 17:49 ` [PATCH 0/4] workqueue: Introduce low-level unbound wq sysfs cpumask v4 Frederic Weisbecker
2015-03-13 6:02 ` Mike Galbraith
2015-03-18 4:40 ` [PATCH 0/4 V5] workqueue: Introduce low-level unbound wq sysfs cpumask v5 Lai Jiangshan
2015-03-18 4:40 ` [PATCH 1/4 V5] workqueue: Reorder sysfs code Lai Jiangshan
2015-03-24 15:41 ` Tejun Heo
2015-03-18 4:40 ` [PATCH 2/4 V5] workqueue: split apply_workqueue_attrs() into 3 stages Lai Jiangshan
2015-03-24 15:55 ` Tejun Heo
2015-03-18 4:40 ` [PATCH 3/4 V5] workqueue: Create low-level unbound workqueues cpumask Lai Jiangshan
2015-03-18 4:40 ` [PATCH 4/4 V5] workqueue: Allow modifying low level unbound workqueue cpumask Lai Jiangshan
2015-03-24 17:31 ` Tejun Heo
2015-03-31 7:46 ` Lai Jiangshan
2015-04-01 8:33 ` Lai Jiangshan
2015-04-01 15:52 ` Tejun Heo
2015-03-19 8:54 ` [PATCH 0/4 V5] workqueue: Introduce low-level unbound wq sysfs cpumask v5 Mike Galbraith
2015-04-02 11:14 ` [PATCH 0/4 V6] " Lai Jiangshan
2015-04-02 11:14 ` [PATCH 1/4 V6] workqueue: Reorder sysfs code Lai Jiangshan
2015-04-06 15:22 ` Tejun Heo
2015-04-02 11:14 ` [PATCH 2/4 V6] workqueue: split apply_workqueue_attrs() into 3 stages Lai Jiangshan
2015-04-06 15:39 ` Tejun Heo
2015-04-02 11:14 ` [PATCH 3/4 V6] workqueue: Create low-level unbound workqueues cpumask Lai Jiangshan
2015-04-02 11:14 ` [PATCH 4/4 V6] workqueue: Allow modifying low level unbound workqueue cpumask Lai Jiangshan
2015-04-06 15:53 ` Tejun Heo
2015-04-07 1:25 ` Lai Jiangshan
2015-04-07 1:58 ` Tejun Heo [this message]
2015-04-07 2:33 ` Lai Jiangshan
2015-04-07 11:26 ` [PATCH 1/3 V7] workqueue: split apply_workqueue_attrs() into 3 stages Lai Jiangshan
2015-04-07 11:26 ` [PATCH 2/3 V7] workqueue: Create low-level unbound workqueues cpumask Lai Jiangshan
2015-04-07 11:26 ` [PATCH 3/3 V7] workqueue: Allow modifying low level unbound workqueue cpumask Lai Jiangshan
2015-04-22 19:39 ` Tejun Heo
2015-04-22 23:02 ` Frederic Weisbecker
2015-04-23 6:29 ` Mike Galbraith
2015-04-17 14:57 ` [PATCH 1/3 V7] workqueue: split apply_workqueue_attrs() into 3 stages Tejun Heo
2015-04-20 3:21 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407015817.GJ10582@htj.duckdns.org \
--to=tj@kernel.org \
--cc=bitbucket@online.de \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=khilman@linaro.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).