From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751841AbbDGFGq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Apr 2015 01:06:46 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:41231 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750840AbbDGFGn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Apr 2015 01:06:43 -0400
Date: Tue, 7 Apr 2015 00:06:40 -0500
From: Andy Gross <agross@codeaurora.org>
To: Sricharan R <sricharan@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
        galak@codeaurora.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, iivanov@mm-sol.com,
        srichara@qti.qualcomm.com
Subject: Re: [PATCH V2 2/6] i2c: qup: Add V2 tags support
Message-ID: <20150407050640.GB9225@qualcomm.com>
References: <1428345067-21878-1-git-send-email-sricharan@codeaurora.org>
 <1428345067-21878-3-git-send-email-sricharan@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1428345067-21878-3-git-send-email-sricharan@codeaurora.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 07, 2015 at 12:01:03AM +0530, Sricharan R wrote:

<snip>

> +static u32 qup_i2c_send_data(struct qup_i2c_dev *qup, int tlen, u8 *tbuf,
> +			     int dlen, u8 *dbuf)
> +{
> +	u32 val = 0, idx = 0, pos = 0, i = 0, t;
> +	int  len = tlen + dlen;
> +	u8 *buf = tbuf;
> +
> +	while (len > 0) {
> +		if (qup_i2c_wait_ready(qup, QUP_OUT_FULL, 0, 4)) {

Instead of 0 and 4 can we use some #defines?  This applies for all of the
i2c_wait_ready calls

<snip>


-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project