From: Dan Carpenter <dan.carpenter@oracle.com>
To: Giedrius Statkevicius <giedrius.statkevicius@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: dgnc: improve the coding style in unlocking part of dgnc_tty_write()
Date: Tue, 7 Apr 2015 11:25:33 +0300 [thread overview]
Message-ID: <20150407082533.GX16501@mwanda> (raw)
In-Reply-To: <20150407081953.GW16501@mwanda>
On Tue, Apr 07, 2015 at 11:19:53AM +0300, Dan Carpenter wrote:
> On Tue, Apr 07, 2015 at 11:17:48AM +0300, Dan Carpenter wrote:
> > This patch changes the lock ordering (behavior change) and it's not
> > described in the changelog. Please figure out which way is the correct
> > ordering and resend.
>
> Actually the original ordering was obviously correct. You can't take
> a mutex if you are holding a spinlock. So it always has to be:
>
> mutex_lock();
> spin_lock();
>
> spin_unlock();
> mutext_unlock();
>
Oh, hm... You could take a mutex with trylock I suppose. That would be
safe.
Anyway, I just saw that you sent a v2 patch.
When you send a v2 patch, then you *must* send a reply to the original
thread. Greg has thousands and thousands of messages in his inbox and
he applies patches in chronological order. So he will apply this one
because it has not responses then get to the v2 patch and try to apply
that one as well which will fail.
regards,
dan carpenter
prev parent reply other threads:[~2015-04-07 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 21:15 [PATCH 1/3] staging: dgnc: use a real mutex instead of masquerading a semaphore as a mutex Giedrius Statkevicius
2015-04-05 21:15 ` [PATCH 2/3] staging: dgnc: remove redundant check Giedrius Statkevicius
2015-04-05 21:15 ` [PATCH 3/3] staging: dgnc: improve the coding style in unlocking part of dgnc_tty_write() Giedrius Statkevicius
2015-04-07 8:17 ` Dan Carpenter
2015-04-07 8:19 ` Dan Carpenter
2015-04-07 8:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407082533.GX16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=giedrius.statkevicius@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).