linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Willy Tarreau <willy@meta-x.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: panel: remove duplicate code
Date: Tue, 7 Apr 2015 12:45:23 +0300	[thread overview]
Message-ID: <20150407094522.GZ16501@mwanda> (raw)
In-Reply-To: <20150407092502.GA20278@sudip-PC>

On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
> > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
> > 
> > I hadn't looked at this driver much before.  It sucks that
> > parport_driver ->attach() functions can't fail... 
> 
> then maybe, we can change the code of parport. currently attach and
> parport_register_driver never fails. we can modify it so that if attach
> fails then parport_register_driver will also fail. will not be that much
> difficult as it has been used only in 13 places.
> your views ?

If you write the patch then I will review it.  :)

> 
> and since we are discussing parallel ports, few days back i saw one
> post in ubuntuforums that his scanner is not working because of
> lack of ppscsi.I mailed Tim Waugh, but he is not interested to work
> with ppscsi anymore. parallel port scanners are almost a thing of the past
> now. do you think it is worth that i pick up the code and modify
> it for our latest kernel and submit to Greg ?

If you want to do the work, I won't say no! :P

regards,
dan carpenter


  parent reply	other threads:[~2015-04-07  9:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07  8:25 [PATCH] staging: panel: remove duplicate code Sudip Mukherjee
2015-04-07  8:49 ` Dan Carpenter
2015-04-07  9:25   ` Sudip Mukherjee
2015-04-07  9:44     ` Greg Kroah-Hartman
2015-04-07  9:56       ` Sudip Mukherjee
2015-04-07 10:12         ` Greg Kroah-Hartman
2015-04-07 14:14           ` Willy Tarreau
2015-04-07 14:21             ` Sudip Mukherjee
2015-04-07 14:33               ` Willy Tarreau
2015-04-07 14:41           ` Sudip Mukherjee
2015-04-07  9:45     ` Dan Carpenter [this message]
2015-04-07 10:36       ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407094522.GZ16501@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=willy@meta-x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).