From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753250AbbDGKMM (ORCPT ); Tue, 7 Apr 2015 06:12:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48847 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824AbbDGKMJ (ORCPT ); Tue, 7 Apr 2015 06:12:09 -0400 Date: Tue, 7 Apr 2015 12:12:06 +0200 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Dan Carpenter , Willy Tarreau , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: panel: remove duplicate code Message-ID: <20150407101206.GA7431@kroah.com> References: <1428395101-20098-1-git-send-email-sudipm.mukherjee@gmail.com> <20150407084930.GD10964@mwanda> <20150407092502.GA20278@sudip-PC> <20150407094429.GA6880@kroah.com> <20150407095658.GA27740@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150407095658.GA27740@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote: > On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote: > > > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote: > > > > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote: > > > > > > > > I hadn't looked at this driver much before. It sucks that > > > > parport_driver ->attach() functions can't fail... > > > > > > then maybe, we can change the code of parport. currently attach and > > > parport_register_driver never fails. we can modify it so that if attach > > > fails then parport_register_driver will also fail. will not be that much > > > difficult as it has been used only in 13 places. > > > your views ? > > > > > > and since we are discussing parallel ports, few days back i saw one > > > post in ubuntuforums that his scanner is not working because of > > > lack of ppscsi.I mailed Tim Waugh, but he is not interested to work > > > with ppscsi anymore. parallel port scanners are almost a thing of the past > > > now. do you think it is worth that i pick up the code and modify > > > it for our latest kernel and submit to Greg ? > > > > If you have some parport hardware, and want to take it on, that would be > > great. The code needs a maintainer, and the apis are _really_ old and > > messy, as you have found out. > what kind of parport hardware will you suggest? No idea, go look at the drivers and code to figure that out.