From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932390AbbDHOmQ (ORCPT ); Wed, 8 Apr 2015 10:42:16 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56933 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932368AbbDHOmN (ORCPT ); Wed, 8 Apr 2015 10:42:13 -0400 Date: Wed, 8 Apr 2015 15:42:05 +0100 From: Mark Brown To: Laxman Dewangan Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org Message-ID: <20150408144205.GZ6023@sirena.org.uk> References: <1428500280-3421-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8KAC7izW+t6+YejF" Content-Disposition: inline In-Reply-To: <1428500280-3421-1-git-send-email-ldewangan@nvidia.com> X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: max8973: get rid of extra variable for gpio validity X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8KAC7izW+t6+YejF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 08, 2015 at 07:08:00PM +0530, Laxman Dewangan wrote: > To find that dvs-gpio is valid or not, gpio API gpio_is_valid() > can be directly used instead of intermediate variable. >=20 > Removing the extra variable and using the gpio_is_valid(). Are you sure that platform data using 0 as default/unset is still handled correctly after this? --8KAC7izW+t6+YejF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVJT48AAoJECTWi3JdVIfQsgEH/1yNIgYoFoNZxA0DLyOMsAyr fQtI+opn+MNi4D/vFjv2aH6kbUaobDJGF9FZbI7bpGyERI3Xz4+vjfu8pQ6RwuJH 6IkhNeXbHvZ8whWLAFpI+9Uj/LBymA+5CwD90mKK8A3n8PNQpUVXyMQlruziF574 L/mzYIjKCiZlkarpr7uat2H7QMs+DRRvgMfdQprwd6JHrfRMqDLJUhvTX1N028O2 KvZh+sSxMYWI7v5XGgF5DvgSw9Xj/LZVOsAJHsXQhnMHRIyMrB66BvLZzRspTJ4f 8bcsT1GIf0RzC3FJWURR0SRbV9t2yVGzBxMqy0egzXKJ9Y+k9sW81TewPvTJFC0= =xt3O -----END PGP SIGNATURE----- --8KAC7izW+t6+YejF--