From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932891AbbDIIkE (ORCPT ); Thu, 9 Apr 2015 04:40:04 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57894 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932846AbbDIIjw (ORCPT ); Thu, 9 Apr 2015 04:39:52 -0400 Date: Thu, 9 Apr 2015 10:39:47 +0200 From: Jan Kara To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH V2 6/9 linux-next] udf: bug on exotic flag in udf_get_filename() Message-ID: <20150409083947.GF18044@quack.suse.cz> References: <1428521039-18491-1-git-send-email-fabf@skynet.be> <1428521039-18491-7-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428521039-18491-7-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 08-04-15 21:23:56, Fabian Frederick wrote: > UDF volume is only mounted with UDF_FLAG_UTF8 > or UDF_FLAG_NLS_MAP (see fill udf_fill_super(). > BUG() if we have something different in udf_get_filename() > > Suggested-by: Jan Kara > Signed-off-by: Fabian Frederick Thanks. Merged. Honza > --- > fs/udf/unicode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c > index 488a838..f37123b 100644 > --- a/fs/udf/unicode.c > +++ b/fs/udf/unicode.c > @@ -365,7 +365,7 @@ int udf_get_filename(struct super_block *sb, uint8_t *sname, int slen, > goto out2; > } > } else > - goto out2; > + BUG(); > > ret = udf_translate_to_linux(dname, dlen, > filename->u_name, filename->u_len, > -- > 1.9.1 > -- Jan Kara SUSE Labs, CR