From: Lee Jones <lee.jones@linaro.org>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
DT <devicetree@vger.kernel.org>,
David Dajun Chen <david.chen@diasemi.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
INPUT <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH V1 2/2] devicetree: Add bindings for DA9063 OnKey
Date: Thu, 9 Apr 2015 10:21:38 +0100 [thread overview]
Message-ID: <20150409092138.GA3467@x1> (raw)
In-Reply-To: <addbebc419ed2d693d398e07131c119cd1d4160b.1428504804.git.stwiss.opensource@diasemi.com>
On Wed, 08 Apr 2015, Steve Twiss wrote:
> From: Steve Twiss <stwiss.opensource@diasemi.com>
What format is this? Why aren't you using `git send-email`?
> Add device tree bindings for the DA9063 OnKey driver
>
> This patch is dependent on PATCH V1 1/2
How can there be dependencies between a binding document and a driver
patch?
> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
>
> ---
> This patch applies against linux-next and v4.0-rc6
>
>
> Documentation/devicetree/bindings/mfd/da9063.txt | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/da9063.txt b/Documentation/devicetree/bindings/mfd/da9063.txt
> index 42c6fa6..3449b75 100644
> --- a/Documentation/devicetree/bindings/mfd/da9063.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9063.txt
> @@ -2,9 +2,10 @@
>
> DA9093 consists of a large and varied group of sub-devices (I2C Only):
>
> -Device Supply Names Description
> ------- ------------ -----------
> +Device Supply Names Description
> +------ ------------ -----------
> da9063-regulator : : LDOs & BUCKs
> +da9063-onkey : : On Key
> da9063-rtc : : Real-Time Clock
> da9063-watchdog : : Watchdog
>
> @@ -51,6 +52,18 @@ Sub-nodes:
> the DA9063. There are currently no entries in this binding, however
> compatible = "dlg,da9063-rtc" should be added if a node is created.
>
> +- onkey : This node defines the OnKey settings for controlling the key
> + functionality of the device. The node should contain the compatible keyword
s/keyword/property/
> + with the value "dlg,da9063-onkey".
> +
> + The platform data needs to match the OTP content of high address register
It's wrong to mention platform data here. Just tell us what the
property is for.
> + DA9063_REG_CONFIG_I and the device tree entry "dlg,disable-key-power" can
I feel like you're burying the dlg,disable-key-power documentation in
side a long winded paragraph. It's better to start the line with it,
like:
Optional Properties:
dlg,disable-key-power: Disable power-down using a long key-press. If
absent <blah> ...
> + be used to control this. If the onkey node contains "dlg,disable-key-power"
> + then the power down using a long key-press is disabled. If this entry is
> + missing then by default the key-press triggered power down is enabled.
> + By toggling this key-power keyword the OnKey driver will support KEY_POWER
> + and KEY_SLEEP key presses.
> +
> - watchdog : This node defines settings for the Watchdog timer associated
> with the DA9063. There are currently no entries in this binding, however
> compatible = "dlg,da9063-watchdog" should be added if a node is created.
> @@ -73,6 +86,11 @@ Example:
> compatible = "dlg,da9063-watchdog";
> };
>
> + onkey {
> + compatible = "dlg,da9063-onkey";
> + dlg,disable-key-power;
> + };
> +
> regulators {
> DA9063_BCORE1: bcore1 {
> regulator-name = "BCORE1";
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-04-09 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 14:53 [PATCH V1 0/2] Add OnKey support for DA9063 Steve Twiss
2015-04-08 14:53 ` [PATCH V1 1/2] input: misc: da9063: OnKey driver Steve Twiss
2015-04-09 8:47 ` Paul Bolle
2015-04-09 10:12 ` Opensource [Steve Twiss]
2015-04-09 12:01 ` Paul Bolle
2015-04-08 14:53 ` [PATCH V1 2/2] devicetree: Add bindings for DA9063 OnKey Steve Twiss
2015-04-09 9:21 ` Lee Jones [this message]
2015-04-09 10:31 ` Opensource [Steve Twiss]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409092138.GA3467@x1 \
--to=lee.jones@linaro.org \
--cc=david.chen@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).